ffrgb / meshviewer

lib/filters/filtergui.js

define(function () {
  'use strict';

  return function (distributor) {
    var container = document.createElement('ul');
    container.classList.add('filters');
    var div = document.createElement('div');

    function render(el) {
      el.appendChild(div);

The variable div is changed as part of the for-each loop for example by document.createElement("div") on line 7. Only the value of the last iteration will be visible in this function if it is called after the loop.

    }

    function filtersChanged(filters) {
      while (container.firstChild) {
        container.removeChild(container.firstChild);
      }

      filters.forEach(function (d) {
        var li = document.createElement('li');
        container.appendChild(li);
        d.render(li);

        var button = document.createElement('button');
        button.classList.add('ion-close');
        button.setAttribute('aria-label', _.t('remove'));
        button.onclick = function onclick() {
          distributor.removeFilter(d);
        };
        li.appendChild(button);
      });

      if (container.parentNode === div && filters.length === 0) {
        div.removeChild(container);
      } else if (filters.length > 0) {
        div.appendChild(container);
      }
    }

    return {
      render: render,
      filtersChanged: filtersChanged
    };
  };
});