ClosureUsePrinter::convert() - Code Metrics - Inspection of "Servel enhancments" - fezfez/php-to-zephir - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#35)

by Saif Eddin

created 2018-04-02 21:11 UTC

ClosureUsePrinter::convert() A

↳ Parent: ClosureUsePrinter

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	3.1852

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	3
cts	9
cp	0.3333
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	1
crap	3.1852

<?php

namespace PhpToZephir\Converter\Printer\Expr;

use PhpToZephir\Logger;
use PhpParser\Node\Expr;
use PhpToZephir\ReservedWordReplacer;
use PhpToZephir\Converter\Dispatcher;

class ClosureUsePrinter
{
    /**
     * @var Dispatcher
     */
    private $dispatcher = null;
    /**
     * @var Logger
     */
    private $logger = null;
    /**
     * @var ReservedWordReplacer
     */
    private $reservedWordReplacer = null;

    /**
     * @param Dispatcher           $dispatcher
     * @param Logger               $logger
     * @param ReservedWordReplacer $reservedWordReplacer
     */
    public function __construct(Dispatcher $dispatcher, Logger $logger, ReservedWordReplacer $reservedWordReplacer)
    {
        $this->dispatcher = $dispatcher;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->logger = $logger;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->reservedWordReplacer = $reservedWordReplacer;
    }

    public static function getType()
    {
        return 'pExpr_ClosureUse';
    }

    /**
     * @param Expr\ClosureUse $node
     *
     * @return string
     */
    public function convert(Expr\ClosureUse $node)
    {
        if ($node->byRef) {
            $this->logger->logNode(
                'Zephir not support reference parameters for now. Stay tuned for https://github.com/phalcon/zephir/issues/203',

                $node,
                $this->dispatcher->getMetadata()->getClass()
            );
        }

        return $this->reservedWordReplacer->replace($node->var);
    }
}


1		<?php
2
3		namespace PhpToZephir\Converter\Printer\Expr;
4
5		use PhpToZephir\Logger;
6		use PhpParser\Node\Expr;
7		use PhpToZephir\ReservedWordReplacer;
8		use PhpToZephir\Converter\Dispatcher;
9
10		class ClosureUsePrinter
11		{
12		/**
13		* @var Dispatcher
14		*/
15		private $dispatcher = null;
16		/**
17		* @var Logger
18		*/
19		private $logger = null;
20		/**
21		* @var ReservedWordReplacer
22		*/
23		private $reservedWordReplacer = null;
24
25		/**
26		* @param Dispatcher $dispatcher
27		* @param Logger $logger
28		* @param ReservedWordReplacer $reservedWordReplacer
29		*/
30	1	public function __construct(Dispatcher $dispatcher, Logger $logger, ReservedWordReplacer $reservedWordReplacer)
31		{
32	1	$this->dispatcher = $dispatcher;
		0 ignored issues – show Coding Style introduced 2016-11-24 11:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
33	1	$this->logger = $logger;
		0 ignored issues – show Coding Style introduced 2016-11-24 11:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 15 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
34	1	$this->reservedWordReplacer = $reservedWordReplacer;
35	1	}
36
37	1	public static function getType()
38		{
39	1	return 'pExpr_ClosureUse';
40		}
41
42		/**
43		* @param Expr\ClosureUse $node
44		*
45		* @return string
46		*/
47	1	public function convert(Expr\ClosureUse $node)
48		{
49	1	if ($node->byRef) {
50		$this->logger->logNode(
51		'Zephir not support reference parameters for now. Stay tuned for https://github.com/phalcon/zephir/issues/203',
		0 ignored issues – show Coding Style introduced 2016-11-24 11:42 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 127 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
52		$node,
53		$this->dispatcher->getMetadata()->getClass()
54		);
55		}
56
57	1	return $this->reservedWordReplacer->replace($node->var);
58		}
59		}
60

fezfez / php-to-zephir

Pull Request — master (#35)

ClosureUsePrinter::convert() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like