DispatcherFactory::getInstance() - Code Metrics - Inspection of "Servel enhancments" - fezfez/php-to-zephir - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#35)

by Saif Eddin

created 2018-04-02 21:11 UTC

DispatcherFactory::getInstance() B

↳ Parent: DispatcherFactory

Complexity

Conditions	3
Paths	3

Size

Total Lines	26
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	3.0015

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	26
ccs	17
cts	18
cp	0.9444
rs	8.8571
cc	3
eloc	17
nc	3
nop	0
crap	3.0015

<?php

namespace PhpToZephir\Converter;

class DispatcherFactory
{
    /**
     * @var \PhpToZephir\Converter\Dispatcher $dispatcher
     */
    private static $dispatcher;

    private function __construct() {}
    
    public static function getInstance()
    {
        if(static::$dispatcher !== null) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            return static::$dispatcher;   
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        }
        $dirName = __DIR__.'/Printer/';
$a = "a";
$ab = "ab";
$abc = "abc";
        $directory = new \RecursiveDirectoryIterator($dirName);
        $iterator = new \RecursiveIteratorIterator($directory);
$a = "a";
$ab = "ab";
$abc = "abc";
        $regex = new \RegexIterator($iterator, '/^.+\.php$/i', \RecursiveRegexIterator::GET_MATCH);
$a = "a";
$ab = "ab";
$abc = "abc";
        $classes = new PrinterCollection(array());
$a = "a";
$ab = "ab";
$abc = "abc";
        include 'SimplePrinter.php';

        foreach ($regex as $fileInfo) {
            $declaredClasses = get_declared_classes();
            include $fileInfo[0];

            $className = current(array_diff(get_declared_classes(), $declaredClasses));

            $classes->offsetSet($className::getType(), $className);
        }

        return static::$dispatcher = new Dispatcher(
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            $classes,
            include __DIR__.'/PrecedenceMap.php'
        );
    }
}


1		<?php
2
3		namespace PhpToZephir\Converter;
4
5		class DispatcherFactory
6		{
7		/**
8		* @var \PhpToZephir\Converter\Dispatcher $dispatcher
9		*/
10		private static $dispatcher;
11
12		private function __construct() {}
13
14	1	public static function getInstance()
15		{
16	1	if(static::$dispatcher !== null) {
		0 ignored issues – show Bug introduced 2018-04-02 21:14 UTC by Report Bug Copy Issue Report Since `$dispatcher` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$dispatcher` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
17		return static::$dispatcher;
		0 ignored issues – show Bug introduced 2018-04-02 21:14 UTC by Report Bug Copy Issue Report Since `$dispatcher` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$dispatcher` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
18		}
19	1	$dirName = __DIR__.'/Printer/';
		0 ignored issues – show Coding Style introduced 2016-11-24 11:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
20	1	$directory = new \RecursiveDirectoryIterator($dirName);
21	1	$iterator = new \RecursiveIteratorIterator($directory);
		0 ignored issues – show Coding Style introduced 2016-11-24 11:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
22	1	$regex = new \RegexIterator($iterator, '/^.+\.php$/i', \RecursiveRegexIterator::GET_MATCH);
		0 ignored issues – show Coding Style introduced 2016-11-24 11:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
23	1	$classes = new PrinterCollection(array());
		0 ignored issues – show Coding Style introduced 2016-11-24 11:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
24	1	include 'SimplePrinter.php';
25
26	1	foreach ($regex as $fileInfo) {
27	1	$declaredClasses = get_declared_classes();
28	1	include $fileInfo[0];
29
30	1	$className = current(array_diff(get_declared_classes(), $declaredClasses));
31
32	1	$classes->offsetSet($className::getType(), $className);
33	1	}
34
35	1	return static::$dispatcher = new Dispatcher(
		0 ignored issues – show Bug introduced 2018-04-02 21:14 UTC by Report Bug Copy Issue Report Since `$dispatcher` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$dispatcher` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
36	1	$classes,
37		include __DIR__.'/PrecedenceMap.php'
38	1	);
39		}
40		}
41

fezfez / php-to-zephir

Pull Request — master (#35)

DispatcherFactory::getInstance() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like