ClassInformation::build() - Code Metrics - Inspection of "Servel enhancments" - fezfez/php-to-zephir - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#35)

by Saif Eddin

created 2018-04-02 21:11 UTC

ClassInformation::build() C

↳ Parent: ClassInformation

Complexity

Conditions	15
Paths	12

Size

Total Lines	43
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	25
CRAP Score	21.4215

Importance

Changes

Metric	Value
dl	0
loc	43
ccs	25
cts	36
cp	0.6944
rs	5.0504
c	0
b	0
f	0
cc	15
eloc	30
nc	12
nop	2
crap	21.4215

How to fix Complexity

<?php

namespace PhpToZephir\Converter;

use PhpParser\Node\Stmt;
use PhpToZephir\ReservedWordReplacer;
use PhpToZephir\NodeFetcher;

class ClassInformation
{
    /**
     * @var ReservedWordReplacer
     */
    private $reservedWordReplacer = null;
    /**
     * @var NodeFetcher
     */
    private $nodeFetcher = null;

    /**
     * @param ReservedWordReplacer $reservedWordReplacer
     * @param NodeFetcher          $nodeFetcher
     */
    public function __construct(ReservedWordReplacer $reservedWordReplacer, NodeFetcher $nodeFetcher)
    {
        $this->reservedWordReplacer = $reservedWordReplacer;
        $this->nodeFetcher = $nodeFetcher;
$a = "a";
$ab = "ab";
$abc = "abc";
    }

    /**
     * @param array $nodes
     *
     * @return \PhpToZephir\Converter\ClassMetadata
     */
    public function getClassesMetdata(array $nodes)
    {
        $classMetadata = new ClassMetadata();

        $classMetadata = $this->build($nodes, $classMetadata);

        $namespace = $classMetadata->getNamespace();

        if ($namespace === null) {
            throw new \Exception('Namespace not found');
        }

        return $classMetadata;
    }

    /**
     * @param array         $nodes
     * @param ClassMetadata $classMetadata
     *
     * @return ClassMetadata
     */
    public function build(array $nodes, ClassMetadata $classMetadata)
    {
        $class = null;
        foreach ($this->nodeFetcher->foreachNodes($nodes) as $nodeData) {
            $node = $nodeData['node'];
            if ($node instanceof Stmt\UseUse) {
                $classMetadata->addUse($node);
                $classMetadata->addClasses($this->reservedWordReplacer->replace(implode('\\', $node->name->parts)));
                if ($node->name->getLast() !== $node->alias) {
                    $classMetadata->addClassesAlias(
                        $node->alias,
                        $this->reservedWordReplacer->replace(implode('\\', $node->name->parts))
                    );
                }
            } elseif ($node instanceof Stmt\Namespace_) {
                $classMetadata->setNamespace(implode('\\', $node->name->parts));
            } elseif ($node instanceof Stmt\Interface_ || $node instanceof Stmt\Class_) {
                if ($class !== null) {
                    throw new \Exception('Multiple class find in '.$fileName);
                }
                $class = $this->reservedWordReplacer->replace($node->name);
                $classMetadata->setClass($class);

                if ($node instanceof Stmt\Interface_ ) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                	
                } elseif ($node instanceof Stmt\Class_ && $node->implements !== null) {
                    $implementsClean = array();
                    foreach ($node->implements as $implement) {
                        $implementsClean[] = $this->reservedWordReplacer->replace(implode('\\', $implement->parts));
                    }
                    $classMetadata->setImplements($implementsClean);
                }
            } elseif ($node instanceof Stmt\Interface_ || $node instanceof Stmt\Class_) {
                if ($class !== null) {
                    throw new \Exception('Multiple class find in '.$fileName);
                }
                $class = $this->reservedWordReplacer->replace($node->name);
                $classMetadata->setClass($class);
            }
        }

        return $classMetadata;
    }
}


1		<?php
2
3		namespace PhpToZephir\Converter;
4
5		use PhpParser\Node\Stmt;
6		use PhpToZephir\ReservedWordReplacer;
7		use PhpToZephir\NodeFetcher;
8
9		class ClassInformation
10		{
11		/**
12		* @var ReservedWordReplacer
13		*/
14		private $reservedWordReplacer = null;
15		/**
16		* @var NodeFetcher
17		*/
18		private $nodeFetcher = null;
19
20		/**
21		* @param ReservedWordReplacer $reservedWordReplacer
22		* @param NodeFetcher $nodeFetcher
23		*/
24	82	public function __construct(ReservedWordReplacer $reservedWordReplacer, NodeFetcher $nodeFetcher)
25		{
26	82	$this->reservedWordReplacer = $reservedWordReplacer;
27	82	$this->nodeFetcher = $nodeFetcher;
		0 ignored issues – show Coding Style introduced 2016-11-24 11:42 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
28	82	}
29
30		/**
31		* @param array $nodes
32		*
33		* @return \PhpToZephir\Converter\ClassMetadata
34		*/
35	82	public function getClassesMetdata(array $nodes)
36		{
37	82	$classMetadata = new ClassMetadata();
38
39	82	$classMetadata = $this->build($nodes, $classMetadata);
40
41	82	$namespace = $classMetadata->getNamespace();
42
43	82	if ($namespace === null) {
44		throw new \Exception('Namespace not found');
45		}
46
47	82	return $classMetadata;
48		}
49
50		/**
51		* @param array $nodes
52		* @param ClassMetadata $classMetadata
53		*
54		* @return ClassMetadata
55		*/
56	82	public function build(array $nodes, ClassMetadata $classMetadata)
57		{
58	82	$class = null;
59	82	foreach ($this->nodeFetcher->foreachNodes($nodes) as $nodeData) {
60	82	$node = $nodeData['node'];
61	82	if ($node instanceof Stmt\UseUse) {
62	4	$classMetadata->addUse($node);
63	4	$classMetadata->addClasses($this->reservedWordReplacer->replace(implode('\\', $node->name->parts)));
64	4	if ($node->name->getLast() !== $node->alias) {
65		$classMetadata->addClassesAlias(
66		$node->alias,
67		$this->reservedWordReplacer->replace(implode('\\', $node->name->parts))
68		);
69		}
70	82	} elseif ($node instanceof Stmt\Namespace_) {
71	82	$classMetadata->setNamespace(implode('\\', $node->name->parts));
72	82	} elseif ($node instanceof Stmt\Interface_ \|\| $node instanceof Stmt\Class_) {
73	82	if ($class !== null) {
74		throw new \Exception('Multiple class find in '.$fileName);
75		}
76	82	$class = $this->reservedWordReplacer->replace($node->name);
77	82	$classMetadata->setClass($class);
78
79	82	if ($node instanceof Stmt\Interface_ ) {
		0 ignored issues – show Unused Code introduced 2016-11-24 11:42 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
80
81	82	} elseif ($node instanceof Stmt\Class_ && $node->implements !== null) {
82	82	$implementsClean = array();
83	82	foreach ($node->implements as $implement) {
84	5	$implementsClean[] = $this->reservedWordReplacer->replace(implode('\\', $implement->parts));
85	82	}
86	82	$classMetadata->setImplements($implementsClean);
87	82	}
88	82	} elseif ($node instanceof Stmt\Interface_ \|\| $node instanceof Stmt\Class_) {
89		if ($class !== null) {
90		throw new \Exception('Multiple class find in '.$fileName);
91		}
92		$class = $this->reservedWordReplacer->replace($node->name);
93		$classMetadata->setClass($class);
94		}
95	82	}
96
97	82	return $classMetadata;
98		}
99		}
100

fezfez / php-to-zephir

Pull Request — master (#35)

ClassInformation::build() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like