evelikto\di\creator\InjectableCreator

Complexity

Total Complexity

4

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	fromClass()	0	15	4

<?php

namespace evelikto\di\creator;
use evelikto\di\{Bean, Injectable};

/** Creates dependency if identifier is a classname implementing the Injectable interface */
trait InjectableCreator
{
    /**
     * Resolves dependency from a given class name. Constructor injection will be used if needed.
     *
     * @param   string      $name   Name of the class to be created
     * @return  Bean|null           Wrapped new $name instance or null if no such class
     * @throws  ClassNotInjectable  If $name is not an Injectable
     */
    protected function fromClass(string $name) {
        if (class_exists($name, true) === false)
            return null;

        if (method_exists($name, '__construct') === false)
            $value = new $name;
        else {
            $method = new \ReflectionMethod($name, '__construct');
            $value = new $name(...$this->autowire($method));

It seems like autowire() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        if ($value instanceof Injectable)
            return new Bean($name, $value);

It seems like $name can also be of type object; however, parameter $name of evelikto\di\Bean::__construct() does only seem to accept string, maybe add an additional type check?

        throw new ClassNotInjectable($name);

It seems like $name can also be of type object; however, parameter $name of evelikto\di\creator\ClassNotInjectable::__construct() does only seem to accept string, maybe add an additional type check?

    }
}