Notifable - Code Metrics - Inspection of "add read & unread methods to trait" - fenos/Notifynder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — version-4 ( 696079...5287d0 )

unknown

created 2016-07-13 12:35 UTC

Notifable A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	4
Bugs	1	Features	2

Metric	Value
c	4
b	1
f	2
dl	0
loc	43
rs	10
wmc	9
lcom	0
cbo	0

6 Methods

Rating	Name	Size	Complexity
A	notifications()	9	2
A	notifynder()	4	1
A	sendNotificationFrom()	4	1
A	sendNotificationTo()	4	1
A	readNotification()	7	2
A	unreadNotification()	7	2

<?php

namespace Fenos\Notifynder\Traits;

use Fenos\Notifynder\Models\Notification;

trait Notifable
{
    public function notifications()
    {
        $model = notifynder_config()->getNotificationModel();
        if (notifynder_config()->isPolymorphic()) {
            return $this->morphMany($model, 'to');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        return $this->hasMany($model, 'to_id');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function notifynder($category)
    {
        return app('notifynder')->category($category);
    }

    public function sendNotificationFrom($category)
    {
        return $this->notifynder($category)->from($this);
    }

    public function sendNotificationTo($category)
    {
        return $this->notifynder($category)->to($this);
    }

    public function readNotification($notification)
    {
        if(!($notification instanceof Notification)) {
            $notification = Notification::firstOrFail($notification);
        }
        return $notification->read();
    }

    public function unreadNotification($notification)
    {
        if(!($notification instanceof Notification)) {
            $notification = Notification::firstOrFail($notification);
        }
        return $notification->unread();
    }
}


1			<?php
2
3			namespace Fenos\Notifynder\Traits;
4
5			use Fenos\Notifynder\Models\Notification;
6
7			trait Notifable
8			{
9			public function notifications()
10			{
11			$model = notifynder_config()->getNotificationModel();
12			if (notifynder_config()->isPolymorphic()) {
13			return $this->morphMany($model, 'to');
			0 ignored issues – show Bug introduced 2016-06-17 14:28 UTC by Report Bug Copy Issue Report It seems like `morphMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
14			}
15
16			return $this->hasMany($model, 'to_id');
			0 ignored issues – show Bug introduced 2016-06-17 14:28 UTC by Report Bug Copy Issue Report It seems like `hasMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17			}
18
19			public function notifynder($category)
20			{
21			return app('notifynder')->category($category);
22			}
23
24			public function sendNotificationFrom($category)
25			{
26			return $this->notifynder($category)->from($this);
27			}
28
29			public function sendNotificationTo($category)
30			{
31			return $this->notifynder($category)->to($this);
32			}
33
34			public function readNotification($notification)
35			{
36			if(!($notification instanceof Notification)) {
37			$notification = Notification::firstOrFail($notification);
38			}
39			return $notification->read();
40			}
41
42			public function unreadNotification($notification)
43			{
44			if(!($notification instanceof Notification)) {
45			$notification = Notification::firstOrFail($notification);
46			}
47			return $notification->unread();
48			}
49			}
50

fenos / Notifynder

Push — version-4 ( 696079...5287d0 )

Notifable A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Duplication Side-by-Side

Filter issues like