Fenos\Notifynder\Parsers\ArtisanOptionsParser::parse()

Complexity

Conditions	5
Paths	6

Size

Total Lines	39
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	1

<?php
    public function parse($fields)
    {
        if (! $fields) {
            return [];
        }

        // name:string, age:integer
        // name:string(10,2), age:integer
        $fields = preg_split('/\s?,\s/', $fields);

        $parsed = [];

        foreach ($fields as $index => $field) {
            // Example:
            // name:string:nullable => ['name', 'string', 'nullable']
            // name:string(15):nullable
            $chunks = preg_split('/\s?:\s?/', $field, null);

            // The first item will be our property
            $property = array_shift($chunks);

            $args = null;

            // Finally, anything that remains will
            // be our decorators
            $decorators = $chunks;

            $parsed[$index] = $property;

            if (isset($args)) {
                $parsed[$index]['args'] = $args;
            }
            if ($decorators) {

The expression $decorators of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                $parsed[$index]['decorators'] = $decorators;
            }
        }

        return $parsed;
    }
}