Fenos\Notifynder\Senders\SenderFactory

Complexity

Total Complexity

9

Size/Duplication

Total Lines	104
Duplicated Lines	8.65 %

Coupling/Cohesion

Components	2
Dependencies	3

Importance

Changes	4
Bugs	3	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getSender()	0	15	3
A	sendSingle()	0	4	1
A	sendMultiple()	0	4	1
A	sendGroup()	0	9	1
A	isMultiArray()	9	9	2

<?php

namespace Fenos\Notifynder\Senders;

/*
 * Class NotifynderSenderFactory
 *
 * @package Fenos\Notifynder
 */
use Fenos\Notifynder\Builder\NotifynderBuilder;
use Fenos\Notifynder\Contracts\NotifynderCategory;
use Fenos\Notifynder\Contracts\NotifynderGroup;

/**
 * Class SenderFactory.
 */
class SenderFactory
{
    /**
     * @var NotifynderGroup
     */
    protected $notifynderGroup;

    /**
     * @var NotifynderCategory
     */
    private $notifynderCategory;

    /**
     * @param NotifynderGroup    $notifynderGroup
     * @param NotifynderCategory $notifynderCategory
     */
    public function __construct(NotifynderGroup $notifynderGroup,
                         NotifynderCategory $notifynderCategory)
    {
        $this->notifynderGroup = $notifynderGroup;
        $this->notifynderCategory = $notifynderCategory;
    }

    /**
     * Get the right sender when the data is
     * passed.
     *
     * @param  array                $infoNotifications
     * @param                       $category
     * @return SendMultiple|SendOne
     */
    public function getSender($infoNotifications, $category = null)
    {
        if ($infoNotifications instanceof NotifynderBuilder) {
            $infoNotifications = $infoNotifications->toArray();
        }

        // if the array is multidimensional
        // it means that we want to send
        // multiple notifications
        if ($this->isMultiArray($infoNotifications)) {
            return $this->sendMultiple($infoNotifications);
        } else {
            return $this->sendSingle($infoNotifications, $category);
        }
    }

    /**
     * Send Single Notification Sender.
     *
     * @param  array   $infoNotifications
     * @param          $category
     * @return SendOne
     */
    public function sendSingle(array $infoNotifications, $category)
    {
        return new SendOne($infoNotifications, $category);

The call to SendOne::__construct() has too many arguments starting with $category.

    }

    /**
     * Send Multiple Notification Sender.
     *
     * @param  array        $infoNotifications
     * @return SendMultiple
     */
    public function sendMultiple(array $infoNotifications)
    {
        return new SendMultiple($infoNotifications);
    }

    /**
     * Get the the send group instance.
     *
     * @param  string           $groupName
     * @param  array | \Closure $info
     * @return SendGroup
     */
    public function sendGroup($groupName, array $info)
    {
        return new SendGroup(
            $this->notifynderGroup,
            $this->notifynderCategory,
            $groupName,
            $info
        );
    }

    /**
     * Check if the array passed is
     * multidimensional.
     *
     * @param $arr
     * @return bool
     */
    protected function isMultiArray(array $arr)

This method seems to be duplicated in your project.

    {
        $rv = array_filter($arr, 'is_array');
        if (count($rv) > 0) {
            return true;
        }

        return false;
    }
}