Fenos\Notifynder\Artisan\PushCategoryToGroup

Complexity

Total Complexity

7

Size/Duplication

Total Lines	106
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	4
Bugs	3	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	fire()	0	19	3
A	getArgumentsConsole()	0	12	1
A	getArguments()	0	6	1
A	getOptions()	0	6	1

<?php

namespace Fenos\Notifynder\Artisan;

use Fenos\Notifynder\Contracts\NotifynderGroup;
use Fenos\Notifynder\Parsers\ArtisanOptionsParser;
use Illuminate\Console\Command;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Input\InputArgument;

class PushCategoryToGroup extends Command
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'notifynder:push:category';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Associate the categories to a group';

    /**
     * @var NotifynderGroup
     */
    private $notifynderGroup;

    /**
     * @var ArtisanOptionsParser
     */
    private $artisanOptionsParser;

    /**
     * Create a new command instance.
     *
     * @param  NotifynderGroup                              $notifynderGroup
     * @param  ArtisanOptionsParser                         $artisanOptionsParser
     * @return \Fenos\Notifynder\Artisan\PushCategoryToGroup

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct(NotifynderGroup $notifynderGroup,
        ArtisanOptionsParser $artisanOptionsParser)
    {
        parent::__construct();
        $this->notifynderGroup = $notifynderGroup;
        $this->artisanOptionsParser = $artisanOptionsParser;
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function fire()
    {
        $arguments = $this->getArgumentsConsole();

        $categoryGroup = array_shift($arguments);
        $arguments = $arguments[0];
        $categories = explode(',', $arguments);

        $groupCategories = $this->notifynderGroup
            ->addMultipleCategoriesToGroup($categoryGroup, $categories);

The call to NotifynderGroup::addMultipleCategoriesToGroup() has too many arguments starting with $categoryGroup.

        if ($groupCategories) {
            foreach ($groupCategories->categories as $category) {
                $this->info("Category {$category->name} has been associated to the group {$groupCategories->name}");
            }
        } else {
            $this->error('The name must be a string with dots as namespaces');
        }
    }

    /**
     * @return array|string
     */
    public function getArgumentsConsole()
    {
        $names = $this->argument('name');

        $categories = $this->option('categories');

        $categories = $this->artisanOptionsParser->parse($categories);

It seems like $categories defined by $this->artisanOptionsParser->parse($categories) on line 86 can also be of type array; however, Fenos\Notifynder\Parsers\ArtisanOptionsParser::parse() does only seem to accept string, maybe add an additional type check?

        array_unshift($categories, $names);

        return $categories;
    }

    /**
     * Get the console command arguments.
     *
     * @return array
     */
    protected function getArguments()
    {
        return [
            ['name', InputArgument::REQUIRED, 'user.post.add'],
        ];
    }

    /**
     * Get the console command options.
     *
     * @return array
     */
    protected function getOptions()
    {
        return [
            ['categories', null, InputOption::VALUE_OPTIONAL, 'notifynder.name', []],
        ];
    }
}