NotificationRepository - Code Metrics - Inspection of "fixed limit argument caused merged PR" - fenos/Notifynder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 697c1d...a37fe5 )

by Fabrizio

created 2016-03-15 09:43 UTC

NotificationRepository A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	356
Duplicated Lines	22.75 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	7
Bugs	3	Features	2

Metric	Value
wmc	29
c	7
b	3
f	2
lcom	1
cbo	1
dl	81
loc	356
rs	10

17 Methods

Rating	Name	Duplication	Size	Complexity
A	find()	0	4	1
A	storeSingle()	0	4	1
A	delete()	0	4	1
A	__construct()	0	7	1
A	storeMultiple()	0	6	1
A	readOne()	0	10	2
A	readLimit()	0	11	1
A	readAll()	0	6	1
A	deleteAll()	0	9	1
A	deleteByCategory()	0	15	2
A	deleteLimit()	0	16	2
B	getNotRead()	26	26	5
B	getAll()	25	25	5
A	countNotRead()	10	10	1
A	getLastNotification()	9	9	1
A	getLastNotificationByCategory()	11	11	1
A	applyFilter()	0	10	2

How to fix Duplicated Code

<?php namespace Fenos\Notifynder\Notifications;

use Closure;
use Fenos\Notifynder\Contracts\NotificationDB;
use Fenos\Notifynder\Models\Notification;
use Illuminate\Database\DatabaseManager;
use Illuminate\Database\Connection;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Query\Builder as BuilderDB;

/**
 * Class NotificationRepository
 *
 * @package Fenos\Notifynder\Senders
 */
class NotificationRepository implements NotificationDB
{

    /**
     * @var Notification | Builder | BuilderDB
     */
    protected $notification;

    /**
     * @var $db DatabaseManager | Connection
     */
    protected $db;

    /**
     * @param Notification                         $notification
     * @param \Illuminate\Database\DatabaseManager $db
     */
    public function __construct(
        Notification $notification,
        DatabaseManager $db
    ) {
        $this->notification = $notification;
        $this->db = $db;
    }

    /**
     * Find notification by id
     *
     * @param $notification_id
     * @return \Illuminate\Database\Eloquent\Collection|\Illuminate\Database\Eloquent\Model|static
     */
    public function find($notification_id)
    {
        return $this->notification->find($notification_id);

    }

    /**
     * Save a single notification sent
     *
     * @param  array $info
     * @return Notification
     */
    public function storeSingle(array $info)
    {
        return $this->notification->create($info);
    }

    /**
     * Save multiple notifications sent
     * at once
     *
     * @param  array $info
     * @return mixed
     */
    public function storeMultiple(array $info)
    {
        return $this->db->table(
            $this->notification->getTable()
        )->insert($info);
    }

    /**
     * Make Read One Notification
     *
     * @param  Notification $notification
     * @return bool|Notification
     */
    public function readOne(Notification $notification)
    {
        $notification->read = 1;

        if ($notification->save()) {
            return $notification;
        }

        return false;
    }

    /**
     * Read notifications in base the number
     * Given
     *
     * @param $to_id
     * @param $entity
     * @param $numbers
     * @param $order
     * @return int
     */
    public function readLimit($to_id, $entity, $numbers, $order)
    {
        $notifications = $this->notification->withNotRead()

            ->wherePolymorphic($to_id, $entity)
            ->limit($numbers)
            ->orderBy('id', $order)
            ->lists('id');

        return $this->notification->whereIn('id', $notifications)
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            ->update(['read' => 1]);
    }

    /**
     * Make read all notification not read
     *
     * @param $to_id
     * @param $entity
     * @return int
     */
    public function readAll($to_id, $entity)
    {
        return $this->notification->withNotRead()

            ->wherePolymorphic($to_id, $entity)
            ->update(['read' => 1]);
    }

    /**
     * Delete a notification giving the id
     * of it
     *
     * @param $notification_id
     * @return Bool
     */
    public function delete($notification_id)
    {
        return $this->notification->where('id', $notification_id)->delete();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * Delete All notifications about the
     * current user
     *
     * @param $to_id int
     * @param $entity
     * @return Bool
     */
    public function deleteAll($to_id, $entity)
    {
        $query = $this->db->table(
            $this->notification->getTable()
        );

        return $this->notification->scopeWherePolymorphic($query, $to_id, $entity)
            ->delete();
    }

    /**
     * Delete All notifications from a
     * defined category
     *
     * @param $category_name int
     * @param $expired       Bool
     * @return Bool
     */
    public function deleteByCategory($category_name, $expired = false)
    {
        $query = $this->notification->whereHas(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            'body',
            function ($q) use ($category_name) {
                $q->where('name', $category_name);
            }
        );

        if ($expired == true) {

            return $query->onlyExpired()->delete();
        }

        return $query->delete();
    }

    /**
     *
     * Delete numbers of notifications equals
     * to the number passing as 2 parameter of
     * the current user
     *
     * @param $user_id    int
     * @param $entity
     * @param $number     int
     * @param $order      string
     * @return int
     * @throws \Exception
     */
    public function deleteLimit($user_id, $entity, $number, $order)
    {
        $notifications_ids = $this->notification

            ->wherePolymorphic($user_id, $entity)
            ->orderBy('id', $order)
            ->select('id')
            ->limit($number)
            ->lists('id');

        if (count($notifications_ids) == 0) {
            return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        return $this->notification->whereIn('id', $notifications_ids)
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            ->delete();
    }

    /**
     * Retrive notifications not Read
     * You can also limit the number of
     * Notification if you don't it will get all
     *
     * @param              $to_id
     * @param              $entity
     * @param  int|null    $limit
     * @param  int|null    $paginate
     * @param  string      $orderDate
     * @param Closure|null $filterScope
     * @return mixed
     */
    public function getNotRead(

        $to_id,
        $entity,
        $limit = null,
        $paginate = null,
        $orderDate = 'desc',
        Closure $filterScope = null
    ) {
        $query = $this->notification->with('body', 'from')
            ->wherePolymorphic($to_id, $entity)
            ->withNotRead()
            ->orderBy('read', 'ASC')
            ->orderBy('created_at', $orderDate);

        if ($limit && !$paginate) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $query->limit($limit);
        }

        $query = $this->applyFilter($filterScope, $query);

        if (is_int(intval($paginate)) && $paginate) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            return $query->paginate($limit);
        }

        return $query->get();
    }

    /**
     * Retrive all notifications, not read
     * in first.
     * You can also limit the number of
     * Notifications if you don't, it will get all
     *
     * @param           $to_id
     * @param           $entity
     * @param  null     $limit
     * @param  int|null $paginate
     * @param  string   $orderDate
     * @param Closure   $filterScope
     * @return mixed
     */
    public function getAll(

        $to_id,
        $entity,
        $limit = null,
        $paginate = null,
        $orderDate = 'desc',
        Closure $filterScope = null
    ) {
        $query = $this->notification->with('body', 'from')
            ->wherePolymorphic($to_id, $entity)
            ->orderBy('read', 'ASC')
            ->orderBy('created_at', $orderDate);

        if ($limit && !$paginate) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $query->limit($limit);
        }

        $query = $this->applyFilter($filterScope, $query);

        if (is_int(intval($paginate)) && $paginate) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            return $query->paginate($limit);
        }

        return $query->get();
    }

    /**
     * get number Notifications
     * not read
     *
     * @param         $to_id
     * @param         $entity
     * @param Closure $filterScope
     * @return mixed
     */
    public function countNotRead($to_id, $entity, Closure $filterScope = null)

    {
        $query = $this->notification->wherePolymorphic($to_id, $entity)

            ->withNotRead()
            ->select($this->db->raw('Count(*) as notRead'));

        $query = $this->applyFilter($filterScope, $query);

        return $query->count();
    }

    /**
     * Get last notification of the current
     * entity
     *
     * @param         $to_id
     * @param         $entity
     * @param Closure $filterScope
     * @return mixed
     */
    public function getLastNotification($to_id, $entity, Closure $filterScope = null)

    {
        $query = $this->notification->wherePolymorphic($to_id, $entity)

            ->orderBy('created_at', 'DESC');

        $query = $this->applyFilter($filterScope, $query);

        return $query->first();
    }

    /**
     * Get last notification of the current
     * entity of a specific category
     *
     * @param         $category
     * @param         $to_id
     * @param         $entity
     * @param Closure $filterScope
     * @return mixed
     */
    public function getLastNotificationByCategory($category, $to_id, $entity, Closure $filterScope = null)

    {
        $query = $this->notification

            ->wherePolymorphic($to_id, $entity)
            ->byCategory($category)
            ->orderBy('created_at', 'desc');

        $query = $this->applyFilter($filterScope, $query);

        return $query->first();
    }

    /**
     * Apply scope filters
     *
     * @param Closure $filterScope
     * @param         $query
     */
    protected function applyFilter(Closure $filterScope = null, $query)
    {
        if ( ! $filterScope) {
            return $query;
        }

        $filterScope($query);

        return $query;
    }
}


1			<?php namespace Fenos\Notifynder\Notifications;
2
3			use Closure;
4			use Fenos\Notifynder\Contracts\NotificationDB;
5			use Fenos\Notifynder\Models\Notification;
6			use Illuminate\Database\DatabaseManager;
7			use Illuminate\Database\Connection;
8			use Illuminate\Database\Eloquent\Builder;
9			use Illuminate\Database\Query\Builder as BuilderDB;
10
11			/**
12			* Class NotificationRepository
13			*
14			* @package Fenos\Notifynder\Senders
15			*/
16			class NotificationRepository implements NotificationDB
17			{
18
19			/**
20			* @var Notification \| Builder \| BuilderDB
21			*/
22			protected $notification;
23
24			/**
25			* @var $db DatabaseManager \| Connection
26			*/
27			protected $db;
28
29			/**
30			* @param Notification $notification
31			* @param \Illuminate\Database\DatabaseManager $db
32			*/
33			public function __construct(
34			Notification $notification,
35			DatabaseManager $db
36			) {
37			$this->notification = $notification;
38			$this->db = $db;
39			}
40

fenos / Notifynder

Push — master ( 697c1d...a37fe5 )

NotificationRepository A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

17 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like