Notification - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/version-4' in..." - fenos/Notifynder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — version-4 ( 2da0bd...27f202 )

unknown

created 2016-07-01 16:02 UTC

Notification A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	132
Duplicated Lines	7.58 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes	27
Bugs	12	Features	10

Metric	Value
c	27
b	12
f	10
dl	10
loc	132
rs	10
wmc	22
lcom	2
cbo	4

14 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	2
A	category()	0	4	1
A	from()	0	8	2
A	to()	0	8	2
A	getCustomFillableFields()	0	4	1
A	mergeFillables()	0	6	1
A	getTemplateBodyAttribute()	0	12	3
A	getTextAttribute()	0	9	2
A	read()	0	4	1
A	unread()	0	4	1
A	resend()	0	7	1
A	isAnonymous()	0	4	1
A	scopeByCategory()	10	11	3
A	scopeByRead()	0	4	1

How to fix Duplicated Code

<?php

namespace Fenos\Notifynder\Models;

use Fenos\Notifynder\Builder\Notification as BuilderNotification;
use Fenos\Notifynder\Parsers\NotificationParser;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Model;

class Notification extends Model
{
    protected $fillable = [
        'to_id',
        'to_type',
        'from_id',
        'from_type',
        'category_id',
        'read',
        'url',
        'extra',
        'expires_at',
        'stack_id',
    ];

    protected $appends = [
        'text',
    ];

    protected $casts = [
        'extra' => 'array',
    ];

    public function __construct($attributes = [])
    {
        $this->fillable($this->mergeFillables());

        if ($attributes instanceof BuilderNotification) {
            $attributes = $attributes->toArray();
        }

        parent::__construct($attributes);
    }

    public function category()
    {
        return $this->belongsTo(NotificationCategory::class, 'category_id');
    }

    public function from()
    {
        if (notifynder_config()->isPolymorphic()) {
            return $this->belongsTo(notifynder_config()->getModel(), 'from_id');
        }

        return $this->morphTo();
    }

    public function to()
    {
        if (notifynder_config()->isPolymorphic()) {
            return $this->belongsTo(notifynder_config()->getModel(), 'to_id');
        }

        return $this->morphTo();
    }

    public function getCustomFillableFields()
    {
        return notifynder_config()->getAdditionalFields();
    }

    protected function mergeFillables()
    {
        $fillables = array_unique($this->getFillable() + $this->getCustomFillableFields());

        return $fillables;
    }

    public function getTemplateBodyAttribute()
    {
        if (notifynder_config()->isTranslated()) {
            $key = notifynder_config()->getTranslationDomain().'.'.$this->category->name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $trans = trans($key);
            if ($trans != $key) {
                return $trans;
            }
        }

        return $this->category->text;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getTextAttribute()
    {
        if (! array_key_exists('text', $this->attributes)) {
            $notifynderParse = new NotificationParser();
            $this->attributes['text'] = $notifynderParse->parse($this);
        }

        return $this->attributes['text'];
    }

    public function read()
    {
        $this->update(['read' => 1]);
    }

    public function unread()
    {
        $this->update(['read' => 0]);
    }

    public function resend()
    {
        $this->updateTimestamps();
        $this->read = 0;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return $this->save();
    }

    public function isAnonymous()
    {
        return is_null($this->from_id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function scopeByCategory(Builder $query, $category)

    {
        $categoryId = $category;
        if ($category instanceof NotificationCategory) {
            $categoryId = $category->getKey();
        } elseif (! is_numeric($category)) {
            $categoryId = NotificationCategory::byName($category)->firstOrFail()->getKey();

        }

        return $query->where('category_id', $categoryId);
    }

    public function scopeByRead(Builder $query, $read = 1)
    {
        return $query->where('read', $read);
    }
}


1		<?php
2
3		namespace Fenos\Notifynder\Models;
4
5		use Fenos\Notifynder\Builder\Notification as BuilderNotification;
6		use Fenos\Notifynder\Parsers\NotificationParser;
7		use Illuminate\Database\Eloquent\Builder;
8		use Illuminate\Database\Eloquent\Model;
9
10		class Notification extends Model
11		{
12		protected $fillable = [
13		'to_id',
14		'to_type',
15		'from_id',
16		'from_type',
17		'category_id',
18		'read',
19		'url',
20		'extra',
21		'expires_at',
22		'stack_id',
23		];
24
25		protected $appends = [
26		'text',
27		];
28
29		protected $casts = [
30		'extra' => 'array',
31		];
32
33		public function __construct($attributes = [])
34		{
35		$this->fillable($this->mergeFillables());
36
37		if ($attributes instanceof BuilderNotification) {
38		$attributes = $attributes->toArray();
39		}
40
41		parent::__construct($attributes);
42		}
43
44		public function category()
45		{
46		return $this->belongsTo(NotificationCategory::class, 'category_id');
47		}
48
49		public function from()
50		{
51		if (notifynder_config()->isPolymorphic()) {
52		return $this->belongsTo(notifynder_config()->getModel(), 'from_id');
53		}
54
55		return $this->morphTo();
56		}
57
58		public function to()
59		{
60		if (notifynder_config()->isPolymorphic()) {
61		return $this->belongsTo(notifynder_config()->getModel(), 'to_id');
62		}
63
64		return $this->morphTo();
65		}
66
67		public function getCustomFillableFields()
68		{
69		return notifynder_config()->getAdditionalFields();
70		}
71
72		protected function mergeFillables()
73		{
74		$fillables = array_unique($this->getFillable() + $this->getCustomFillableFields());
75
76		return $fillables;
77		}
78
79		public function getTemplateBodyAttribute()
80		{
81		if (notifynder_config()->isTranslated()) {
82		$key = notifynder_config()->getTranslationDomain().'.'.$this->category->name;
		0 ignored issues – show Documentation introduced 2016-06-21 15:28 UTC by Report Bug Copy Issue Report The property `category` does not exist on `object<Fenos\Notifynder\Models\Notification>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
83		$trans = trans($key);
84		if ($trans != $key) {
85		return $trans;
86		}
87		}
88
89		return $this->category->text;
		0 ignored issues – show Documentation introduced 2016-06-21 15:28 UTC by Report Bug Copy Issue Report The property `category` does not exist on `object<Fenos\Notifynder\Models\Notification>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
90		}
91
92		public function getTextAttribute()
93		{
94		if (! array_key_exists('text', $this->attributes)) {
95		$notifynderParse = new NotificationParser();
96		$this->attributes['text'] = $notifynderParse->parse($this);
97		}
98
99		return $this->attributes['text'];
100		}
101
102		public function read()
103		{
104		$this->update(['read' => 1]);
105		}
106
107		public function unread()
108		{
109		$this->update(['read' => 0]);
110		}
111
112		public function resend()
113		{
114		$this->updateTimestamps();
115		$this->read = 0;
		0 ignored issues – show Documentation introduced 2016-07-01 12:44 UTC by Report Bug Copy Issue Report The property `read` does not exist on `object<Fenos\Notifynder\Models\Notification>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
116
117		return $this->save();
118		}
119
120		public function isAnonymous()
121		{
122		return is_null($this->from_id);
		0 ignored issues – show Documentation introduced 2016-07-01 16:04 UTC by Report Bug Copy Issue Report The property `from_id` does not exist on `object<Fenos\Notifynder\Models\Notification>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
123		}
124
125	View Code Duplication	public function scopeByCategory(Builder $query, $category)
		0 ignored issues – show Duplication introduced 2016-07-01 15:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
126		{
127		$categoryId = $category;
128		if ($category instanceof NotificationCategory) {
129		$categoryId = $category->getKey();
130		} elseif (! is_numeric($category)) {
131		$categoryId = NotificationCategory::byName($category)->firstOrFail()->getKey();
		0 ignored issues – show Bug introduced 2016-07-01 15:23 UTC by Report Bug Copy Issue Report The method `byName()` does not exist on `Fenos\Notifynder\Models\NotificationCategory`. Did you maybe mean `scopeByName()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
132		}
133
134		return $query->where('category_id', $categoryId);
135		}
136
137		public function scopeByRead(Builder $query, $read = 1)
138		{
139		return $query->where('read', $read);
140		}
141		}
142

fenos / Notifynder

Push — version-4 ( 2da0bd...27f202 )

Notification A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like