OnceSender - Code Metrics - Inspection of "Issue #71 make sender more atomic" - fenos/Notifynder - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — version-4 ( 724d30...f2c70d )

unknown

created 2016-07-01 14:04 UTC

OnceSender A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	5
Bugs	2	Features	1

Metric	Value
c	5
b	2
f	1
dl	0
loc	54
rs	10
wmc	11
lcom	1
cbo	2

4 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	send()	14	4
A	getQuery()	19	4
A	getQueryInstance()	9	2

<?php

namespace Fenos\Notifynder\Senders;

use BadMethodCallException;
use Fenos\Notifynder\Builder\Notification;
use Fenos\Notifynder\Contracts\SenderContract;
use Fenos\Notifynder\Contracts\SenderManagerContract;
use Illuminate\Database\Eloquent\Builder as EloquentBuilder;

class OnceSender implements SenderContract
{
    protected $notifications;

    public function __construct(array $notifications)
    {
        $this->notifications = $notifications;
    }

    public function send(SenderManagerContract $sender)
    {
        $success = true;
        foreach ($this->notifications as $notification) {
            $query = $this->getQuery($notification);
            if (! $query->exists()) {

                $success = $sender->send([$notification]) ? $success : false;
            } else {
                $query->firstOrFail()->resend();
            }
        }

        return $success;
    }

    protected function getQuery(Notification $notification)
    {
        $query = $this->getQueryInstance();
        $query
            ->where('from_id', $notification->from_id)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->where('from_type', $notification->from_type)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->where('to_id', $notification->to_id)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->where('to_type', $notification->to_type)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->where('category_id', $notification->category_id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if (isset($notification->extra) && ! empty($notification->extra)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $extra = $notification->extra;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if (is_array($extra)) {
                $extra = json_encode($extra);
            }
            $query->where('extra', $extra);
        }

        return $query;
    }

    protected function getQueryInstance()
    {
        $model = notifynder_config()->getNotificationModel();
        $query = $model::query();
        if (! ($query instanceof EloquentBuilder)) {
            throw new BadMethodCallException("The query method hasn't return an instance of [".EloquentBuilder::class."].");
        }
        return $query;
    }
}


1			<?php
2
3			namespace Fenos\Notifynder\Senders;
4
5			use BadMethodCallException;
6			use Fenos\Notifynder\Builder\Notification;
7			use Fenos\Notifynder\Contracts\SenderContract;
8			use Fenos\Notifynder\Contracts\SenderManagerContract;
9			use Illuminate\Database\Eloquent\Builder as EloquentBuilder;
10
11			class OnceSender implements SenderContract
12			{
13			protected $notifications;
14
15			public function __construct(array $notifications)
16			{
17			$this->notifications = $notifications;
18			}
19
20			public function send(SenderManagerContract $sender)
21			{
22			$success = true;
23			foreach ($this->notifications as $notification) {
24			$query = $this->getQuery($notification);
25			if (! $query->exists()) {
			0 ignored issues – show Bug introduced 2016-07-01 12:36 UTC by Report Bug Copy Issue Report The method `exists()` does not exist on `Illuminate\Database\Eloquent\Builder`. Did you maybe mean `shouldRunExistsQuery()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
26			$success = $sender->send([$notification]) ? $success : false;
27			} else {
28			$query->firstOrFail()->resend();
29			}
30			}
31
32			return $success;
33			}
34
35			protected function getQuery(Notification $notification)
36			{
37			$query = $this->getQueryInstance();
38			$query
39			->where('from_id', $notification->from_id)
			0 ignored issues – show Documentation introduced 2016-07-01 12:44 UTC by Report Bug Copy Issue Report The property `from_id` does not exist on `object<Fenos\Notifynder\Builder\Notification>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
40			->where('from_type', $notification->from_type)
			0 ignored issues – show Documentation introduced 2016-07-01 12:44 UTC by Report Bug Copy Issue Report The property `from_type` does not exist on `object<Fenos\Notifynder\Builder\Notification>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
41			->where('to_id', $notification->to_id)
			0 ignored issues – show Documentation introduced 2016-07-01 12:44 UTC by Report Bug Copy Issue Report The property `to_id` does not exist on `object<Fenos\Notifynder\Builder\Notification>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
42			->where('to_type', $notification->to_type)
			0 ignored issues – show Documentation introduced 2016-07-01 12:44 UTC by Report Bug Copy Issue Report The property `to_type` does not exist on `object<Fenos\Notifynder\Builder\Notification>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
43			->where('category_id', $notification->category_id);
			0 ignored issues – show Documentation introduced 2016-07-01 12:44 UTC by Report Bug Copy Issue Report The property `category_id` does not exist on `object<Fenos\Notifynder\Builder\Notification>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
44			if (isset($notification->extra) && ! empty($notification->extra)) {
			0 ignored issues – show Documentation introduced 2016-07-01 12:44 UTC by Report Bug Copy Issue Report The property `extra` does not exist on `object<Fenos\Notifynder\Builder\Notification>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
45			$extra = $notification->extra;
			0 ignored issues – show Documentation introduced 2016-07-01 12:44 UTC by Report Bug Copy Issue Report The property `extra` does not exist on `object<Fenos\Notifynder\Builder\Notification>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
46			if (is_array($extra)) {
47			$extra = json_encode($extra);
48			}
49			$query->where('extra', $extra);
50			}
51
52			return $query;
53			}
54
55			protected function getQueryInstance()
56			{
57			$model = notifynder_config()->getNotificationModel();
58			$query = $model::query();
59			if (! ($query instanceof EloquentBuilder)) {
60			throw new BadMethodCallException("The query method hasn't return an instance of [".EloquentBuilder::class."].");
61			}
62			return $query;
63			}
64			}
65

fenos / Notifynder

Push — version-4 ( 724d30...f2c70d )

OnceSender A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like