PhPsst::__construct() - Code Metrics - Inspection of "Updateing composer" - felixsand/PhPsst - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e25ff1...536f4f )

by Felix

created 2016-06-12 07:51 UTC

PhPsst::__construct() A

↳ Parent: PhPsst

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.0932

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	9
ccs	5
cts	7
cp	0.7143
rs	9.6666
cc	2
eloc	6
nc	2
nop	2
crap	2.0932

<?php
/**
 * PhPsst.
 *
 * @copyright Copyright (c) 2016 Felix Sandström
 * @license   MIT
 */

namespace PhPsst;

use Illuminate\Encryption\Encrypter;
use PhPsst\Storage\StorageInterface;

/**
 * A PHP library for distributing (one time) passwords/secrets in a more secure way.
 *
 * @author Felix Sandström <http://github.com/felixsand>
 */
class PhPsst
{
    /**
     * @var StorageInterface
     */
    protected $storage;

    /**
     * @var string
     */
    protected $cipher;

    /**
     * @const string
     */
    const CIPHER_DEFAULT = 'AES-256-CBC';

    /**
     * PhPsst constructor.
     * @param StorageInterface $storage
     * @param string $cipher
     */
    public function __construct(StorageInterface $storage, $cipher = null)
    {
        $this->storage = $storage;
        if ($cipher) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->cipher = $cipher;
        } else {
            $this->cipher = self::CIPHER_DEFAULT;
        }
    }

    /**
     * @param string $password
     * @param int $ttl
     * @param int $views
     * @return string
     */
    public function store($password, $ttl = 3600, $views = 1)
    {
        if (empty($password)) {
            throw new \InvalidArgumentException('The password has to be set');
        }

        $ttl = (int) $ttl;
        if ($ttl < 1) {
            throw new \InvalidArgumentException('TTL has to be higher than 0');
        }

        $views = (int) $views;
        if ($views < 1) {
            throw new \InvalidArgumentException('Views has to be highter han 0');
        }

        $id = uniqid();
        $key = bin2hex(random_bytes(16));
        $encrypter = new Encrypter($key, $this->cipher);

        $this->storage->insert(new Password($id, $encrypter->encrypt($password), $ttl, $views));

        return $id . ';' . $key;
    }

    /**
     * @param $secret
     * @return string
     */
    public function retrieve($secret)
    {
        if (!($idKeyArray = explode(';', $secret)) || count($idKeyArray) != 2) {
            throw new \InvalidArgumentException('Invalid secret');
        }
        list($id, $key) = $idKeyArray;

        if (!($password = $this->storage->get($id))) {
            throw new PhPsstException('No password with that ID found', PhPsstException::NO_PASSWORD_WITH_ID_FOUND);
        }
        $encrypter = new Encrypter($key, $this->cipher);

        $password->decreaseViews();
        if ($password->getViews() > 0) {
            $this->storage->update($password);
        } else {
            $this->storage->delete($password);
        }

        return $encrypter->decrypt($password->getPassword());
    }
}


1		<?php
2		/**
3		* PhPsst.
4		*
5		* @copyright Copyright (c) 2016 Felix Sandström
6		* @license MIT
7		*/
8
9		namespace PhPsst;
10
11		use Illuminate\Encryption\Encrypter;
12		use PhPsst\Storage\StorageInterface;
13
14		/**
15		* A PHP library for distributing (one time) passwords/secrets in a more secure way.
16		*
17		* @author Felix Sandström <http://github.com/felixsand>
18		*/
19		class PhPsst
20		{
21		/**
22		* @var StorageInterface
23		*/
24		protected $storage;
25
26		/**
27		* @var string
28		*/
29		protected $cipher;
30
31		/**
32		* @const string
33		*/
34		const CIPHER_DEFAULT = 'AES-256-CBC';
35
36		/**
37		* PhPsst constructor.
38		* @param StorageInterface $storage
39		* @param string $cipher
40		*/
41	4	public function __construct(StorageInterface $storage, $cipher = null)
42		{
43	4	$this->storage = $storage;
44	4	if ($cipher) {
		0 ignored issues – show Bug Best Practice introduced 2016-06-12 07:59 UTC by Report Bug Copy Issue Report The expression `$cipher` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
45		$this->cipher = $cipher;
46		} else {
47	4	$this->cipher = self::CIPHER_DEFAULT;
48		}
49	4	}
50
51		/**
52		* @param string $password
53		* @param int $ttl
54		* @param int $views
55		* @return string
56		*/
57	7	public function store($password, $ttl = 3600, $views = 1)
58		{
59	7	if (empty($password)) {
60	1	throw new \InvalidArgumentException('The password has to be set');
61		}
62
63	6	$ttl = (int) $ttl;
64	6	if ($ttl < 1) {
65	1	throw new \InvalidArgumentException('TTL has to be higher than 0');
66		}
67
68	5	$views = (int) $views;
69	5	if ($views < 1) {
70	1	throw new \InvalidArgumentException('Views has to be highter han 0');
71		}
72
73	4	$id = uniqid();
74	4	$key = bin2hex(random_bytes(16));
75	4	$encrypter = new Encrypter($key, $this->cipher);
76
77	4	$this->storage->insert(new Password($id, $encrypter->encrypt($password), $ttl, $views));
78
79	4	return $id . ';' . $key;
80		}
81
82		/**
83		* @param $secret
84		* @return string
85		*/
86	6	public function retrieve($secret)
87		{
88	6	if (!($idKeyArray = explode(';', $secret)) \|\| count($idKeyArray) != 2) {
89	1	throw new \InvalidArgumentException('Invalid secret');
90		}
91	5	list($id, $key) = $idKeyArray;
92
93	5	if (!($password = $this->storage->get($id))) {
94	1	throw new PhPsstException('No password with that ID found', PhPsstException::NO_PASSWORD_WITH_ID_FOUND);
95		}
96	4	$encrypter = new Encrypter($key, $this->cipher);
97
98	4	$password->decreaseViews();
99	4	if ($password->getViews() > 0) {
100	2	$this->storage->update($password);
101	2	} else {
102	2	$this->storage->delete($password);
103		}
104
105	4	return $encrypter->decrypt($password->getPassword());
106		}
107		}
108

felixsand / PhPsst

Push — master ( e25ff1...536f4f )

PhPsst::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like