PhPsst\PhPsst

Complexity

Total Complexity

14

Size/Duplication

Total Lines	110
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes	7
Bugs	0	Features	2

4 Methods

Rating	Name	Duplication	Size	Complexity
B	store()	0	24	4
A	__construct()	0	9	2
B	retrieve()	0	22	5
A	generateKey()	0	16	3

<?php
/**
 * PhPsst.
 *
 * @copyright Copyright (c) 2016 Felix Sandström
 * @license   MIT
 */

namespace PhPsst;

use Illuminate\Encryption\Encrypter;
use PhPsst\Storage\Storage;

/**
 * A PHP library for distributing (one time) passwords/secrets in a more secure way.
 *
 * @author Felix Sandström <http://github.com/felixsand>
 */
class PhPsst
{
    /**
     * @var Storage
     */
    protected $storage;

    /**
     * @var string
     */
    protected $cipher;

    /**
     * @const string
     */
    const CIPHER_DEFAULT = 'AES-256-CBC';

    /**
     * PhPsst constructor.
     * @param Storage $storage
     * @param string $cipher
     */
    public function __construct(Storage $storage, $cipher = null)
    {
        $this->storage = $storage;
        if ($cipher !== null) {
            $this->cipher = $cipher;
        } else {
            $this->cipher = self::CIPHER_DEFAULT;
        }
    }

    /**
     * @param string $password
     * @param int $ttl
     * @param int $views
     * @return string
     */
    public function store($password, $ttl = 3600, $views = 1)
    {
        if (empty($password)) {
            throw new \InvalidArgumentException('The password has to be set');
        }

        $ttl = (int) $ttl;
        if ($ttl < 1) {
            throw new \InvalidArgumentException('TTL has to be higher than 0');
        }

        $views = (int) $views;
        if ($views < 1) {
            throw new \InvalidArgumentException('Views has to be highter han 0');
        }

        $id = uniqid();
        $key = $this->generateKey();
        $encrypter = new Encrypter($key, $this->cipher);

        $this->storage->store(new Password($id, $encrypter->encrypt($password), $ttl, $views));

        return $id . ';' . $key;
    }

    /**
     * @param $secret
     * @return string
     */
    public function retrieve($secret)
    {
        if (!($idKeyArray = explode(';', $secret)) || count($idKeyArray) != 2) {
            throw new \InvalidArgumentException('Invalid secret');
        }
        list($id, $key) = $idKeyArray;
        $id = preg_replace("/[^a-zA-Z\d]/", '', $id);

        if (!($password = $this->storage->get($id))) {
            throw new PhPsstException('No password with that ID found', PhPsstException::NO_PASSWORD_WITH_ID_FOUND);
        }
        $encrypter = new Encrypter($key, $this->cipher);

        $password->decreaseViews();
        if ($password->getViews() > 0) {
            $this->storage->store($password, true);
        } else {
            $this->storage->delete($password);
        }

        return $encrypter->decrypt($password->getPassword());
    }

    /**
     * @return string
     */
    protected function generateKey()
    {
        $key = null;

$key is not used, you could remove the assignment.

        switch ($this->cipher) {
            case 'AES-128-CBC':
                $key = bin2hex(random_bytes(8));
                break;
            case 'AES-256-CBC':
                $key = bin2hex(random_bytes(16));
                break;
            default:
                throw new \RuntimeException('Only supported ciphers are AES-128-CBC and AES-256-CBC');
        }

        return $key;
    }
}