template_model

Complexity

Total Complexity

10

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	get_view_name()	0	2	1
A	get_template_list()	0	12	4
A	get_meta()	0	17	5

<?php

class template_model extends Model {

    function get_view_name($template_name) {

It is generally recommended to explicitly declare the visibility for methods.

        return "templates/" . $template_name . "/index";
    }

    /**
     * Load template meta
     * @param string $template_name Name of template
     * @return array|false containing meta of template
     */
    function get_meta($template_name) {

It is generally recommended to explicitly declare the visibility for methods.

        if (empty($template_name)) {
            return false;
        }
        $template_path = APPPATH . "views/templates/" . $template_name;
        $meta_path = $template_path . "/meta.json";

        if (!(is_dir($template_path) && is_file($meta_path))) {
            return false;
        }

        $meta_json = file_get_contents($meta_path);

        if (!$meta_json) {
            return false;
        }
        return json_decode($meta_json, true);
    }

    function get_template_list() {

It is generally recommended to explicitly declare the visibility for methods.

        $file_list = scandir(APPPATH . 'views/templates/');
        foreach ($file_list as $i=>$file) {
            if (!is_dir(APPPATH . "views/templates/$file")
                || strpos($file, '.') === 0
            ) {
                unset($file_list[$i]);
            } else {
                $file_list[$i] = pathinfo($file)['filename'];
            }
        }
        return array_values(array_unique($file_list));

It seems like $file_list can also be of type false; however, parameter $array of array_unique() does only seem to accept array, maybe add an additional type check?

    }

}