GetCertificate::getIntermediate() - Code Metrics - Inspection of "Syntax" - fbett/le-acme2-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (fc5382)

by Fabian

created 2021-12-07 15:18 UTC

GetCertificate::getIntermediate() A

↳ Parent: GetCertificate

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	6
dl	0
loc	14
ccs	0
cts	7
cp	0
rs	10
c	1
b	0
f	0
cc	3
nc	3
nop	0
crap	12

<?php

namespace LE_ACME2\Response\Order;

use LE_ACME2\Response\AbstractResponse;

class GetCertificate extends AbstractResponse {

    protected $_pattern = '~(-----BEGIN\sCERTIFICATE-----[\s\S]+?-----END\sCERTIFICATE-----)~i';


    public function getCertificate() : string {

        if(preg_match_all($this->_pattern, $this->_raw->body, $matches))  {

            return $matches[0][0];
        }

        throw new \RuntimeException('Preg_match_all has returned false - invalid pattern?');
    }

    public function getIntermediate() : string {

        if(preg_match_all($this->_pattern, $this->_raw->body, $matches))  {

            $result = '';

            for($i=1; $i<count($matches[0]); $i++)  {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}

                $result .= "\n" . $matches[0][$i];
            }
            return $result;
        }

        throw new \RuntimeException('Preg_match_all has returned false - invalid pattern?');
    }

    /**
     * @return string[]
     */
    public function getAlternativeLinks() : array {

        $result = [];

        foreach($this->_raw->header as $line) {
            $matches = [];
            preg_match_all('/^link: <(.*)>;rel="alternate"$/', $line, $matches);

            if(isset($matches[1][0])) {
                $result[] = $matches[1][0];
            }
        }

        return $result;
    }
}

1			<?php
2
3			namespace LE_ACME2\Response\Order;
4
5			use LE_ACME2\Response\AbstractResponse;
6
7			class GetCertificate extends AbstractResponse {
8
9			protected $_pattern = '~(-----BEGIN\sCERTIFICATE-----[\s\S]+?-----END\sCERTIFICATE-----)~i';
10
11
12			public function getCertificate() : string {
13
14			if(preg_match_all($this->_pattern, $this->_raw->body, $matches)) {
15
16			return $matches[0][0];
17			}
18
19			throw new \RuntimeException('Preg_match_all has returned false - invalid pattern?');
20			}
21
22			public function getIntermediate() : string {
23
24			if(preg_match_all($this->_pattern, $this->_raw->body, $matches)) {
25
26			$result = '';
27
28			for($i=1; $i<count($matches[0]); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2021-12-07 14:22 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
29
30			$result .= "\n" . $matches[0][$i];
31			}
32			return $result;
33			}
34
35			throw new \RuntimeException('Preg_match_all has returned false - invalid pattern?');
36			}
37
38			/**
39			* @return string[]
40			*/
41			public function getAlternativeLinks() : array {
42
43			$result = [];
44
45			foreach($this->_raw->header as $line) {
46			$matches = [];
47			preg_match_all('/^link: <(.*)>;rel="alternate"$/', $line, $matches);
48
49			if(isset($matches[1][0])) {
50			$result[] = $matches[1][0];
51			}
52			}
53
54			return $result;
55			}
56			}

fbett / le-acme2-php

Branch — master (fc5382)

GetCertificate::getIntermediate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like