AbstractResponse::_isValid() - Code Metrics - Inspection of "Fix: Prevent non existing directory scan" - fbett/le-acme2-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 558a62...4d34e4 )

by Fabian

created 2022-09-12 07:17 UTC

AbstractResponse::_isValid() A

↳ Parent: AbstractResponse

Complexity

Conditions	3
Paths	3

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	3
c	2
b	0
f	0
dl	0
loc	5
ccs	4
cts	4
cp	1
rs	10
cc	3
nc	3
nop	0
crap	3

<?php

namespace LE_ACME2\Response;

use LE_ACME2\Exception;

use LE_ACME2\Connector\RawResponse;

abstract class AbstractResponse {

    /** @var RawResponse $_raw */
    protected $_raw;

    protected $_pattern_header_location = '/^Location: (\S+)$/i';

    /**
     * AbstractResponse constructor.
     *
     * @param RawResponse $raw
     * @throws Exception\InvalidResponse
     * @throws Exception\RateLimitReached
     */
    public function __construct(RawResponse $raw) {

        $this->_raw = $raw;

        if($this->_isRateLimitReached()) {

            $detail = "";
            if(isset($raw->body['type']) && $raw->body['type'] == 'urn:ietf:params:acme:error:rateLimited') {
                $detail = $raw->body['detail'];
            }

            $retryAfterMatches = $this->_preg_match_headerLine('/^Retry-After: (.+)$/i');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

            throw new Exception\RateLimitReached(
                $raw->request,
                $detail,
                $retryAfterMatches !== null ? $retryAfterMatches[1] : null

            );
        }

        $result = $this->_isValid();
        if(!$result) {

            $responseStatus = $this->_preg_match_headerLine('/^HTTP\/.* [0-9]{3,} /i');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
            throw new Exception\InvalidResponse(
                $raw,
                isset($responseStatus[1]) ? $responseStatus[1] : null,
            );
        }
    }

    protected function _preg_match_headerLine(string $pattern) : ?array {

        foreach($this->_raw->header as $line) {

            $matches = [];
            if(preg_match($pattern, $line, $matches) === 1) {
                return $matches;
            }
        }
        return null;
    }

    protected function _isRateLimitReached() : bool {
        return $this->_preg_match_headerLine('/^HTTP\/.* 429/i') !== null;
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    protected function _isValid() : bool {

        return $this->_preg_match_headerLine('/^HTTP\/.* 201/i') !== null || //Created
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            $this->_preg_match_headerLine('/^HTTP\/.* 200/i') !== null ||
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            $this->_preg_match_headerLine('/^HTTP\/.* 204/i') !== null;
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    public function getRaw() : RawResponse {
        return $this->_raw;
    }
}

1		<?php
2
3		namespace LE_ACME2\Response;
4
5		use LE_ACME2\Exception;
6
7		use LE_ACME2\Connector\RawResponse;
8
9		abstract class AbstractResponse {
10
11		/** @var RawResponse $_raw */
12		protected $_raw;
13
14		protected $_pattern_header_location = '/^Location: (\S+)$/i';
15
16		/**
17		* AbstractResponse constructor.
18		*
19		* @param RawResponse $raw
20		* @throws Exception\InvalidResponse
21		* @throws Exception\RateLimitReached
22		*/
23	2	public function __construct(RawResponse $raw) {
24
25	2	$this->_raw = $raw;
26
27	2	if($this->_isRateLimitReached()) {
28
29	2	$detail = "";
30	2	if(isset($raw->body['type']) && $raw->body['type'] == 'urn:ietf:params:acme:error:rateLimited') {
31	2	$detail = $raw->body['detail'];
32		}
33
34	2	$retryAfterMatches = $this->_preg_match_headerLine('/^Retry-After: (.+)$/i');
		0 ignored issues – show Bug introduced 2022-09-11 20:53 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$retryAfterMatches` is correct as `$this->_preg_match_heade...^Retry-After: (.+)$/i')` targeting `LE_ACME2\Response\Abstra...preg_match_headerLine()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
35
36	2	throw new Exception\RateLimitReached(
37	2	$raw->request,
38		$detail,
39	2	$retryAfterMatches !== null ? $retryAfterMatches[1] : null
		0 ignored issues – show introduced 2022-09-11 20:53 UTC by Report Bug Copy Issue Report The condition `$retryAfterMatches !== null` is always `false`. Loading history...
40		);
41		}
42
43		$result = $this->_isValid();
44		if(!$result) {
45
46		$responseStatus = $this->_preg_match_headerLine('/^HTTP\/.* [0-9]{3,} /i');
		0 ignored issues – show Bug introduced 2021-12-07 14:22 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$responseStatus` is correct as `$this->_preg_match_heade...HTTP\/.* [0-9]{3,} /i')` targeting `LE_ACME2\Response\Abstra...preg_match_headerLine()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
47		throw new Exception\InvalidResponse(
48		$raw,
49		isset($responseStatus[1]) ? $responseStatus[1] : null,
50		);
51		}
52		}
53
54		protected function _preg_match_headerLine(string $pattern) : ?array {
55
56		foreach($this->_raw->header as $line) {
57
58		$matches = [];
59		if(preg_match($pattern, $line, $matches) === 1) {
60		return $matches;
61		}
62		}
63		return null;
64		}
65
66	2	protected function _isRateLimitReached() : bool {
67	2	return $this->_preg_match_headerLine('/^HTTP\/.* 429/i') !== null;
		0 ignored issues – show Bug introduced 2021-12-07 14:22 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->_preg_match_headerLine('/^HTTP\/.* 429/i')` targeting `LE_ACME2\Response\Abstra...preg_match_headerLine()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
68		}
69
70	1	protected function _isValid() : bool {
71
72	1	return $this->_preg_match_headerLine('/^HTTP\/.* 201/i') !== null \|\| //Created
		0 ignored issues – show Bug introduced 2021-12-07 14:22 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->_preg_match_headerLine('/^HTTP\/.* 201/i')` targeting `LE_ACME2\Response\Abstra...preg_match_headerLine()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
73	1	$this->_preg_match_headerLine('/^HTTP\/.* 200/i') !== null \|\|
		0 ignored issues – show Bug introduced 2021-12-07 14:22 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->_preg_match_headerLine('/^HTTP\/.* 200/i')` targeting `LE_ACME2\Response\Abstra...preg_match_headerLine()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
74	1	$this->_preg_match_headerLine('/^HTTP\/.* 204/i') !== null;
		0 ignored issues – show Bug introduced 2021-12-07 14:22 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->_preg_match_headerLine('/^HTTP\/.* 204/i')` targeting `LE_ACME2\Response\Abstra...preg_match_headerLine()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
75		}
76
77		public function getRaw() : RawResponse {
78		return $this->_raw;
79		}
80		}

fbett / le-acme2-php

Push — master ( 558a62...4d34e4 )

AbstractResponse::_isValid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like