LE_ACME2\Utilities\ChallengeHTTP::fetch()

Complexity

Conditions	4
Paths	4

Size

Total Lines	37
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function fetch(string $domain, string $token) : string {

        $requestURL = 'http://' . $domain . '/.well-known/acme-challenge/' . $token;
        $handle = curl_init();
        curl_setopt($handle, CURLOPT_URL, $requestURL);
        curl_setopt($handle, CURLOPT_FOLLOWLOCATION, true);
        curl_setopt($handle, CURLOPT_RETURNTRANSFER, true);

        $response = curl_exec($handle);

        if(curl_errno($handle)) {

            throw new Exception\HTTPAuthorizationInvalid(
                'Error while testing HTTP challenge for "' . $domain . '"": ' .
                $domain . '/.well-known/acme-challenge/' . $token . PHP_EOL .
                '- CURL error: ' . curl_error($handle)
            );
        }

        $statusCode = curl_getinfo($handle, CURLINFO_HTTP_CODE);
        if(substr($statusCode, 0, 1) != 2) {
            throw new Exception\HTTPAuthorizationInvalid(
                'Error while testing HTTP challenge for "' . $domain . '"": ' .
                $domain . '/.well-known/acme-challenge/' . $token .
                ' - unexpected status code:  ' . $statusCode
            );
        }

        if($response === false) {
            throw new Exception\HTTPAuthorizationInvalid(
                'HTTP challenge for "' . $domain . '"": ' .
                $domain . '/.well-known/acme-challenge/' . $token .
                ' tested, found invalid. CURL response: ' . var_export($response, true)
            );
        }

        return $response;

The expression return $response could return the type true which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}