GetNewNonce::getNonce() - Code Metrics - fbett/le-acme2-php - Measure and Improve Code Quality continuously with Scrutinizer

GetNewNonce::getNonce() A
last analyzed 2024-12-11 23:02 UTC

↳ Parent: GetNewNonce

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	2
dl	0
loc	4
ccs	0
cts	3
cp	0
rs	10
c	1
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php

namespace LE_ACME2\Response;

class GetNewNonce extends AbstractResponse {

    protected $_pattern = '/^Replay\-Nonce: (\S+)$/i';

    protected function _isValid() : bool {
        return $this->_preg_match_headerLine($this->_pattern) !== null;
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    public function getNonce() : string {

        $matches = $this->_preg_match_headerLine($this->_pattern);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        return trim($matches[1]);
    }
}

1			<?php
2
3			namespace LE_ACME2\Response;
4
5			class GetNewNonce extends AbstractResponse {
6
7			protected $_pattern = '/^Replay\-Nonce: (\S+)$/i';
8
9			protected function _isValid() : bool {
10			return $this->_preg_match_headerLine($this->_pattern) !== null;
			0 ignored issues – show Bug introduced 2021-12-07 14:22 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->_preg_match_headerLine($this->_pattern)` targeting `LE_ACME2\Response\Abstra...preg_match_headerLine()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
11			}
12
13			public function getNonce() : string {
14
15			$matches = $this->_preg_match_headerLine($this->_pattern);
			0 ignored issues – show Bug introduced 2021-12-07 14:22 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$matches` is correct as `$this->_preg_match_headerLine($this->_pattern)` targeting `LE_ACME2\Response\Abstra...preg_match_headerLine()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
16			return trim($matches[1]);
17			}
18			}

fbett / le-acme2-php

GetNewNonce::getNonce() A last analyzed 2024-12-11 23:02 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

GetNewNonce::getNonce() A
last analyzed 2024-12-11 23:02 UTC