LE_ACME2Tests\Authorizer\HTTPTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testNonExistingDirectoryPath()	0	8	1
A	testDirectoryPath()	0	10	2
A	__construct()	0	4	1

<?php
namespace LE_ACME2Tests\Authorizer;

use LE_ACME2Tests\AbstractLeAcme2TestCase;
use LE_ACME2Tests\TestHelper;

/**
 * @covers \LE_ACME2\Authorizer\HTTP
 */
class HTTPTest extends AbstractLeAcme2TestCase {

    private $_directoryPath;

    public function __construct(string $name) {
        parent::__construct($name);

        $this->_directoryPath = TestHelper::getInstance()->getTempPath() . 'acme-challenges/';

It seems like getTempPath() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function testNonExistingDirectoryPath() {

        $this->assertTrue(\LE_ACME2\Authorizer\HTTP::getDirectoryPath() === null);

        $this->catchExpectedException(
            \RuntimeException::class,
            function() {
                \LE_ACME2\Authorizer\HTTP::setDirectoryPath(TestHelper::getInstance()->getNonExistingPath());

It seems like getNonExistingPath() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        );
    }

    public function testDirectoryPath() {

        if(!file_exists($this->_directoryPath)) {
            mkdir($this->_directoryPath);
        }

        \LE_ACME2\Authorizer\HTTP::setDirectoryPath($this->_directoryPath);

        $this->assertTrue(
            \LE_ACME2\Authorizer\HTTP::getDirectoryPath() === $this->_directoryPath
        );
    }
}