Response::__construct() - Code Metrics - Inspection of "WIP: Use modern php requirements and standards" - fazland/skebby-rest-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#16)

by Alessandro

created 2021-03-15 13:18 UTC

Response::__construct() B

↳ Parent: Project

Complexity

Conditions	11
Paths	71

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	22
CRAP Score	11.209

Importance

Changes

Metric	Value
dl	0
loc	45
ccs	22
cts	25
cp	0.88
rs	7.3166
c	0
b	0
f	0
cc	11
nc	71
nop	1
crap	11.209

How to fix Complexity

<?php

declare(strict_types=1);

namespace Fazland\SkebbyRestClient\DataStructure;

use Fazland\SkebbyRestClient\Constant\SendMethods;
use Fazland\SkebbyRestClient\Exception\EmptyResponseException;
use Fazland\SkebbyRestClient\Exception\UnknownErrorResponseException;
use Fazland\SkebbyRestClient\Exception\XmlLoadException;
use Throwable;

use function libxml_get_errors;
use function libxml_use_internal_errors;
use function simplexml_load_string;
use function sprintf;

/**
 * Represents a Skebby Response.
 */
class Response
{
    private string $status;

    private ?string $code = null;
    private ?string $errorMessage = null;
    private ?string $messageId = null;

    /**
     * @throws EmptyResponseException
     * @throws UnknownErrorResponseException
     */
    public function __construct(string $rawResponse)
    {
        if (empty($rawResponse)) {
            throw new EmptyResponseException();
        }

        $doc = null;

        $useErrors = libxml_use_internal_errors(true);
        try {
            $doc = @simplexml_load_string($rawResponse);

            if ($doc === false) {
                throw new XmlLoadException($rawResponse, libxml_get_errors());
            }
        } catch (Throwable $e) {
            throw new UnknownErrorResponseException($e->getMessage(), $rawResponse, $e);
        } finally {
            libxml_use_internal_errors($useErrors);
        }

        foreach (SendMethods::all() as $method) {
            if (! isset($doc->$method)) {
                continue;
            }

            $element = $doc->$method;

            if (! isset($element->status)) {
                throw new UnknownErrorResponseException('Missing response status value from Skebby', $rawResponse);
            }

            $this->status = (string) $element->status;
            $this->messageId = isset($element->id) ? (string) $element->id : null;

            if (! $this->isSuccessful()) {
                $this->code = isset($element->code) ? (string) $element->code : null;
                $this->errorMessage = isset($element->message) ? (string) $element->message : 'Unknown error';
            }

            return;
        }

        throw new UnknownErrorResponseException('Missing response status value from Skebby', $rawResponse);
    }

    /**
     * Gets the status.
     */
    public function getStatus(): string
    {
        return $this->status;
    }

    /**
     * Whether the response is successful or not.
     */
    public function isSuccessful(): bool
    {
        return $this->status === 'success';
    }

    /**
     * Gets the code.
     */
    public function getCode(): ?string
    {
        return $this->code;
    }

    /**
     * Gets the error message.
     */
    public function getErrorMessage(): ?string
    {
        return $this->errorMessage;
    }

    /**
     * Gets the message id.
     */
    public function getMessageId(): ?string
    {
        return $this->messageId;
    }

    public function __toString(): string
    {
        return sprintf('Response status: %s, code: %s, error_message: %s, message_id: %s', $this->status, $this->status ?? '', $this->errorMessage ?? '', $this->messageId ?? '');
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Fazland\SkebbyRestClient\DataStructure;
6
7		use Fazland\SkebbyRestClient\Constant\SendMethods;
8		use Fazland\SkebbyRestClient\Exception\EmptyResponseException;
9		use Fazland\SkebbyRestClient\Exception\UnknownErrorResponseException;
10		use Fazland\SkebbyRestClient\Exception\XmlLoadException;
11		use Throwable;
12
13		use function libxml_get_errors;
14		use function libxml_use_internal_errors;
15		use function simplexml_load_string;
16		use function sprintf;
17
18		/**
19		* Represents a Skebby Response.
20		*/
21		class Response
22		{
23		private string $status;
		0 ignored issues – show Bug introduced 2021-03-15 11:11 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_STRING, expecting T_FUNCTION or T_CONST Loading history...
24		private ?string $code = null;
25		private ?string $errorMessage = null;
26		private ?string $messageId = null;
27
28		/**
29		* @throws EmptyResponseException
30		* @throws UnknownErrorResponseException
31		*/
32		public function __construct(string $rawResponse)
33		{
34		if (empty($rawResponse)) {
35		throw new EmptyResponseException();
36		}
37
38		$doc = null;
39
40		$useErrors = libxml_use_internal_errors(true);
41		try {
42		$doc = @simplexml_load_string($rawResponse);
43	8
44		if ($doc === false) {
45	8	throw new XmlLoadException($rawResponse, libxml_get_errors());
46	1	}
47		} catch (Throwable $e) {
48		throw new UnknownErrorResponseException($e->getMessage(), $rawResponse, $e);
49	7	} finally {
50		libxml_use_internal_errors($useErrors);
51	7	}
52
53	7	foreach (SendMethods::all() as $method) {
54		if (! isset($doc->$method)) {
55	7	continue;
56	7	}
57
58		$element = $doc->$method;
59
60	7	if (! isset($element->status)) {
61	7	throw new UnknownErrorResponseException('Missing response status value from Skebby', $rawResponse);
62		}
63
64	7	$this->status = (string) $element->status;
65	7	$this->messageId = isset($element->id) ? (string) $element->id : null;
66	7
67		if (! $this->isSuccessful()) {
68		$this->code = isset($element->code) ? (string) $element->code : null;
69	7	$this->errorMessage = isset($element->message) ? (string) $element->message : 'Unknown error';
70		}
71	7
72	1	return;
73		}
74
75	6	throw new UnknownErrorResponseException('Missing response status value from Skebby', $rawResponse);
76	6	}
77
78	6	/**
79	1	* Gets the status.
80	1	*/
81		public function getStatus(): string
82		{
83	6	return $this->status;
84		}
85
86		/**
87		* Whether the response is successful or not.
88		*/
89		public function isSuccessful(): bool
90		{
91		return $this->status === 'success';
92		}
93
94	1	/**
95		* Gets the code.
96	1	*/
97		public function getCode(): ?string
98		{
99		return $this->code;
100		}
101
102		/**
103		* Gets the error message.
104	6	*/
105		public function getErrorMessage(): ?string
106	6	{
107		return $this->errorMessage;
108		}
109
110		/**
111		* Gets the message id.
112		*/
113		public function getMessageId(): ?string
114		{
115		return $this->messageId;
116		}
117
118		public function __toString(): string
119		{
120		return sprintf('Response status: %s, code: %s, error_message: %s, message_id: %s', $this->status, $this->status ?? '', $this->errorMessage ?? '', $this->messageId ?? '');
121		}
122		}
123

fazland / skebby-rest-client

Pull Request — master (#16)

Response::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like