Faytekin\LZW\LZW

Complexity

Total Complexity

13

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	charAt()	0	7	2
A	compress()	0	31	5
A	decompress()	0	30	5
A	uniChr()	0	3	1

<?php

namespace Faytekin\LZW;

class LZW
{
    public function compress(string $uncompress): string
    {
        $dictSize = 256;
        $dictionary = [];

        for ($i = 0; $i < 256; $i++) {
            $dictionary[$this->uniChr($i)] = $i;
        }

        $w = '';
        $result = [];

        for ($i = 0; $i < strlen($uncompress); $i++) {
            $c = $this->charAt($uncompress, $i);
            $wc = $w.$c;

            if (isset($dictionary[$wc])) {
                $w = $wc;
            } else {
                array_push($result, $dictionary[$w]);

                $dictionary[$wc] = $dictSize++;
                $w = strval($c);
            }
        }

        if ($w != '') {
            array_push($result, $dictionary[$w]);
        }

        return implode(',', $result);
    }

    public function decompress(string $compressed): ?string
    {
        $compressed = explode(',', $compressed);
        $dictSize = 256;
        $dictionary = [];

        for ($i = 1; $i < $dictSize; $i++) {
            $dictionary[$i] = $this->uniChr($i);
        }

        $w = $this->uniChr($compressed[0]);

$compressed[0] of type string is incompatible with the type integer expected by parameter $u of Faytekin\LZW\LZW::uniChr().

        $result = $w;

        for ($i = 1; $i < count($compressed); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $k = $compressed[$i];

            if (isset($dictionary[$k])) {
                $entry = $dictionary[$k];
            } elseif ($k == $dictSize) {
                $entry = $w.$this->charAt($w, 0);
            } else {
                return null;
            }

            $result .= $entry;
            $dictionary[$dictSize++] = $w.$this->charAt($entry, 0);
            $w = $entry;
        }

        return $result;
    }

    public function charAt(string $string, int $index): ?string
    {
        if ($index < mb_strlen($string)) {
            return mb_substr($string, $index, 1, 'UTF-8');
        }

        return null;
    }

    public function uniChr(int $u): string
    {
        return mb_convert_encoding('&#'.intval($u).';', 'UTF-8', 'HTML-ENTITIES');

The expression return mb_convert_encoding('&#' . intval($u) . ';', 'UTF-8', 'HTML-ENTITIES') could return the type array which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}