CloudWatchScript\Plugins\SftpMonitoring

Complexity

Total Complexity

7

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	getMetric()	0	15	4
A	getUnit()	0	4	1
A	getAlarms()	0	8	1

<?php
namespace CloudWatchScript\Plugins;

use CloudWatchScript\AbstractMonitoring;

/**
 * Check Solr using ping URL.
 * Add and configure the folliwong lines to the config file
 * "Sftp" : {
 *         "name" : "Name of metric and alarm",
 *         "addr": "127.0.0.1",
 *         "port": "22",
 *         "login": "login",
 *         "password": "password",
 *         "namespace": "Metric/Namespace",
 *         "description": "Descrption"
 * }
 */
class SftpMonitoring extends AbstractMonitoring
{
    private $addr;
    private $port;
    private $login;
    private $password;
    /**
     * @param array $config
     * @param String $name
     */
    public function __construct($config, $name)
    {
        parent::__construct($config, $name);
        $this->addr = $this->config->addr;
        $this->port = $this->config->port;
        $this->login = $this->config->login;
        $this->password = $this->config->password;
    }
    /**
     * Check solr ping url.
     * @return metric 0 KO, 1 OK
     */
    public function getMetric()
    {
        $connection = ssh2_connect($this->addr, $this->port);
        if ($connection === false) {
            return 0;
        }
        if (ssh2_auth_password($connection, $this->login, $this->password) == false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            return 0;
        }
        $sftp = ssh2_sftp($connection);
        if ($sftp === false) {
            return 0;
        }
        return 1;
    }
    /**
     * @return string "None"
     */
    public function getUnit()
    {
        return "None";
    }
    /**
     * @return integer 1
     */
    public function getAlarms()
    {
        return array(
                    array("ComparisonOperator" => "LessThanThreshold",
                          "Threshold" => 1,
                          "Name" => $this->name)
                    );
    }
}