CloudWatchScript\Plugins\HttpMonitoring

Complexity

Total Complexity

6

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getMetric()	0	8	3
A	getUnit()	0	4	1
A	getAlarms()	0	8	1

<?php
namespace CloudWatchScript\Plugins;

use CloudWatchScript\AbstractMonitoring;

/**
 * Check Solr using ping URL.
 * Add and configure the folliwong lines to the config file
 * "Http" : {
 *         "name" : "Name of metric and alarm",
 *         "url": "http://localhost:8080/solr/collection1/admin/ping",
 *         "pattern": "ds",
 *         "namespace": "Metric/Namespace",
 *         "description": "Descrption"
 * }
 */
class HttpMonitoring extends AbstractMonitoring
{
    private $url;
    private $pattern;
    /**
     * @param array $config
     * @param String $name
     */
    public function __construct($config, $name)
    {
        parent::__construct($config, $name);
        $this->url = $this->config->url;
        $this->pattern = $this->config->pattern;
    }
    /**
     * Check solr ping url.
     * @return metric 0 Ok, 1 KO
     */
    public function getMetric()
    {
        $result = @file_get_contents($this->url);
        if ($result === false) {
            return 0;
        }
        return ereg($this->pattern, $result)==true?"1":"0";

It seems like you are loosely comparing ereg($this->pattern, $result) of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

    }
    /**
     * @return string "None"
     */
    public function getUnit()
    {
        return "None";
    }
    /**
     * @return integer 1
     */
    public function getAlarms()
    {
        return array(
                    array("ComparisonOperator" => "LessThanThreshold",
                          "Threshold" => 1,
                          "Name" => $this->name)
                    );
    }
}