ObjectMapper::setPropertyValue() - Code Metrics - Inspection of "Feature/cast upgrade" - fathomminds/php-rest-models - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#61)

unknown

created 2017-11-03 16:09 UTC

ObjectMapper::setPropertyValue() A

↳ Parent: ObjectMapper

Complexity

Conditions	3
Paths	3

Size

Total Lines	18
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	18
ccs	13
cts	13
cp	1
rs	9.4285
cc	3
eloc	13
nc	3
nop	3
crap	3

<?php
namespace Fathomminds\Rest\Helpers;

use Fathomminds\Rest\Exceptions\RestException;

abstract class ObjectMapper
{
    public static function map($object, $map)
    {
        if (gettype($object) !== 'object') {
            throw new RestException('ObjectMapper map method expects object as first parameter', [
                'parameter' => $object,
            ]);
        }
        if (!is_array($map)) {
            throw new RestException('ObjectMapper map method expects array as second parameter', [
                'parameter' => $map,
            ]);
        }
        $mappedObject = new \StdClass();
        foreach ($map as $targetFieldName => $sourceFieldName) {
            list($propertyExists, $propertyValue) = static::getPropertyValue($object, $sourceFieldName);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
            if ($propertyExists) {
                $mappedObject = static::setPropertyValue(
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
                    $mappedObject,
                    $targetFieldName,
                    $propertyValue
                );
            }
        }
        return $mappedObject;
    }

    private static function setPropertyValue($mappedObject, $targetFieldName, $propertyValue)
    {
        $fieldNameArr = explode('.', $targetFieldName);
        $fieldName = array_shift($fieldNameArr);
        if (count($fieldNameArr) !== 0) {
            if (!property_exists($mappedObject, $fieldName)) {
                $mappedObject->{$fieldName} = new \StdClass();
            }
            $mappedObject->{$fieldName} = static::setPropertyValue(
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
                $mappedObject->{$fieldName},
                implode('.', $fieldNameArr),
                $propertyValue
            );
            return $mappedObject;
        }
        $mappedObject->{$fieldName} = $propertyValue;
        return $mappedObject;
    }

    private static function getPropertyValue($object, $sourceFieldName)
    {
        $fieldNameArr = explode('.', $sourceFieldName);
        $fieldName = array_shift($fieldNameArr);
        if (!property_exists($object, $fieldName)) {
            return [
                false,
                null
            ];
        }
        if (count($fieldNameArr) === 0) {
            return [
                true,
                json_decode(json_encode($object->{$fieldName}))
            ];
        }
        return static::getPropertyValue($object->{$fieldName}, implode('.', $fieldNameArr));
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
    }
}


1		<?php
2		namespace Fathomminds\Rest\Helpers;
3
4		use Fathomminds\Rest\Exceptions\RestException;
5
6		abstract class ObjectMapper
7		{
8	3	public static function map($object, $map)
9		{
10	3	if (gettype($object) !== 'object') {
11	1	throw new RestException('ObjectMapper map method expects object as first parameter', [
12	1	'parameter' => $object,
13		]);
14		}
15	2	if (!is_array($map)) {
16	1	throw new RestException('ObjectMapper map method expects array as second parameter', [
17	1	'parameter' => $map,
18		]);
19		}
20	1	$mappedObject = new \StdClass();
21	1	foreach ($map as $targetFieldName => $sourceFieldName) {
22	1	list($propertyExists, $propertyValue) = static::getPropertyValue($object, $sourceFieldName);
		0 ignored issues – show Bug introduced 2017-11-03 16:11 UTC by Report Bug Copy Issue Report Since `getPropertyValue()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `getPropertyValue()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
23	1	if ($propertyExists) {
24	1	$mappedObject = static::setPropertyValue(
		0 ignored issues – show Bug introduced 2017-11-03 16:11 UTC by Report Bug Copy Issue Report Since `setPropertyValue()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `setPropertyValue()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
25	1	$mappedObject,
26	1	$targetFieldName,
27	1	$propertyValue
28		);
29		}
30		}
31	1	return $mappedObject;
32		}
33
34	1	private static function setPropertyValue($mappedObject, $targetFieldName, $propertyValue)
35		{
36	1	$fieldNameArr = explode('.', $targetFieldName);
37	1	$fieldName = array_shift($fieldNameArr);
38	1	if (count($fieldNameArr) !== 0) {
39	1	if (!property_exists($mappedObject, $fieldName)) {
40	1	$mappedObject->{$fieldName} = new \StdClass();
41		}
42	1	$mappedObject->{$fieldName} = static::setPropertyValue(
		0 ignored issues – show Bug introduced 2017-11-03 16:11 UTC by Report Bug Copy Issue Report Since `setPropertyValue()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `setPropertyValue()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
43	1	$mappedObject->{$fieldName},
44	1	implode('.', $fieldNameArr),
45	1	$propertyValue
46		);
47	1	return $mappedObject;
48		}
49	1	$mappedObject->{$fieldName} = $propertyValue;
50	1	return $mappedObject;
51		}
52
53	1	private static function getPropertyValue($object, $sourceFieldName)
54		{
55	1	$fieldNameArr = explode('.', $sourceFieldName);
56	1	$fieldName = array_shift($fieldNameArr);
57	1	if (!property_exists($object, $fieldName)) {
58		return [
59	1	false,
60		null
61		];
62		}
63	1	if (count($fieldNameArr) === 0) {
64		return [
65	1	true,
66	1	json_decode(json_encode($object->{$fieldName}))
67		];
68		}
69	1	return static::getPropertyValue($object->{$fieldName}, implode('.', $fieldNameArr));
		0 ignored issues – show Bug introduced 2017-11-03 16:11 UTC by Report Bug Copy Issue Report Since `getPropertyValue()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `getPropertyValue()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
70		}
71		}
72

fathomminds / php-rest-models

Pull Request — develop (#61)

ObjectMapper::setPropertyValue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like