Database::select() - Code Metrics - fastpress/framework - Measure and Improve Code Quality continuously with Scrutinizer

Database::select() A
last analyzed 2017-07-26 19:27 UTC

↳ Parent: Database

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	2

<?php

namespace Fastpress\Database;


class Database 
{

    public $conn; 

    function __construct(\PDO $pdo){

        $this->conn = $pdo; 
    }

                    
    function queryHandler($clause, $query, $param){

        if(!$param){
            $stmt = $this->conn->query($query); 
        }

        if($param){
            $stmt = $this->conn->prepare($query); 
            $result = $stmt->execute($param);
        }

        if($clause == 'SELECT'){
            return $stmt->fetchAll(\PDO::FETCH_ASSOC);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }

        if($clause == 'INSERT'){
            return $this->conn->lastInsertId();
        }

        return $stmt->rowCount();
    }

    function select($query, array $param = []){

        $stmt =  $this->queryHandler('SELECT', $query, $param);
        return $stmt; 
    }

    function update($query, array $param = []){

        $stmt =  $this->queryHandler('UPDATE', $query, $param);
        return $stmt; 
    }

    function delete($query, array $param = []){

        $stmt =  $this->queryHandler('DELETE', $query, $param);
        return $stmt; 
    }

    function insert($query, array $param = []){

        $stmt =  $this->queryHandler('INSERT', $query, $param);
        return $stmt; 
    }

}


1			<?php
2
3			namespace Fastpress\Database;
4
5
6			class Database
7			{
8
9			public $conn;
10
11			function __construct(\PDO $pdo){
			0 ignored issues – show Best Practice introduced 2017-07-18 12:10 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
12			$this->conn = $pdo;
13			}
14
15
16			function queryHandler($clause, $query, $param){
			0 ignored issues – show Best Practice introduced 2017-07-18 12:10 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
17			if(!$param){
18			$stmt = $this->conn->query($query);
19			}
20
21			if($param){
22			$stmt = $this->conn->prepare($query);
23			$result = $stmt->execute($param);
24			}
25
26			if($clause == 'SELECT'){
27			return $stmt->fetchAll(\PDO::FETCH_ASSOC);
			0 ignored issues – show Bug introduced 2017-07-18 12:10 UTC by Report Bug Copy Issue Report The variable `$stmt` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
28			}
29
30			if($clause == 'INSERT'){
31			return $this->conn->lastInsertId();
32			}
33
34			return $stmt->rowCount();
35			}
36
37			function select($query, array $param = []){
			0 ignored issues – show Best Practice introduced 2017-07-18 12:10 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
38			$stmt = $this->queryHandler('SELECT', $query, $param);
39			return $stmt;
40			}
41
42			function update($query, array $param = []){
			0 ignored issues – show Best Practice introduced 2017-07-18 12:10 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
43			$stmt = $this->queryHandler('UPDATE', $query, $param);
44			return $stmt;
45			}
46
47			function delete($query, array $param = []){
			0 ignored issues – show Best Practice introduced 2017-07-18 12:10 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
48			$stmt = $this->queryHandler('DELETE', $query, $param);
49			return $stmt;
50			}
51
52			function insert($query, array $param = []){
			0 ignored issues – show Best Practice introduced 2017-07-18 12:10 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
53			$stmt = $this->queryHandler('INSERT', $query, $param);
54			return $stmt;
55			}
56
57			}
58

fastpress / framework

Database::select() A last analyzed 2017-07-26 19:27 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

Database::select() A
last analyzed 2017-07-26 19:27 UTC