familytree365 / php-gedcom

src/Writer/SourRef/Even.php

<?php
/**
 * php-gedcom.
 *
 * php-gedcom is a library for parsing, manipulating, importing and exporting
 * GEDCOM 5.5 files in PHP 5.3+.
 *
 * @author          Xiang Ming <wenqiangliu344@gmail.com>
 * @copyright       Copyright (c) 2010-2013, Xiang Ming
 * @license         MIT
 *
 * @link            http://github.com/mrkrstphr/php-gedcom
 */

namespace Gedcom\Writer\SourRef;

class Even
{
    /**
     * @param int $level
     *
     * @return string
     */
    public static function convert(\Gedcom\Record\SourRef\Even &$even, $level = 0)
    {
        $output = '';

        // $_date;
        $_even = $even->getEven();

The method getEven() does not exist on Gedcom\Record\SourRef\Even. Since you implemented __call, consider adding a @method annotation.

        if (!empty($_even)) {
            $output .= $level.' EVEN '.$_even."\n";

Are you sure $_even of type Gedcom\Record\SourRef\Even|mixed can be used in concatenation?

        } else {
            $output = $level." EVEN\n";
        }
        // level up
        $level++;

        // $_role ROLE
        $_role = $data->getRole();

The variable $data seems to be never defined.

        if (!empty($_role)) {
            $output .= $level.' ROLE '.$_role."\n";
        }

        return $output;
    }
}