familytree365 / php-gedcom

src/Writer/RepoRef.php

<?php
/**
 * php-gedcom.
 *
 * php-gedcom is a library for parsing, manipulating, importing and exporting
 * GEDCOM 5.5 files in PHP 5.3+.
 *
 * @author          Xiang Ming <wenqiangliu344@gmail.com>
 * @copyright       Copyright (c) 2010-2013, Xiang Ming
 * @license         MIT
 *
 * @link            http://github.com/mrkrstphr/php-gedcom
 */

namespace Gedcom\Writer;

class RepoRef
{
    /**
     * @param int $level
     *
     * @return string
     */
    public static function convert(\Gedcom\Record\RepoRef &$reporef, $level)
    {
        $output = '';
        $_repo = $reporef->getRepo();

The method getRepo() does not exist on Gedcom\Record\RepoRef. Since you implemented __call, consider adding a @method annotation.

        if (empty($_sour)) {

The variable $_sour seems to never exist and therefore empty should always be true.

            return $output;
        } else {
            $output .= $level.' REPO '.$_repo."\n";

Are you sure $_repo of type Gedcom\Record\RepoRef|mixed|null can be used in concatenation?

        }
        // level up
        $level++;

        // Note array
        $note = $reporef->getNote();

The method getNote() does not exist on Gedcom\Record\RepoRef. Since you implemented __call, consider adding a @method annotation.

        if (!empty($note) && count($note) > 0) {

It seems like $note can also be of type Gedcom\Record\RepoRef; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

            foreach ($note as $item) {
                $_convert = \Gedcom\Writer\NoteRef::convert($item, $level);
                $output .= $_convert;
            }
        }

        // _caln array
        $_caln = $reporef->getCaln();

The method getCaln() does not exist on Gedcom\Record\RepoRef. Since you implemented __call, consider adding a @method annotation.

        if (!empty($_caln) && count($_caln) > 0) {
            foreach ($_caln as $item) {
                $_convert = \Gedcom\Writer\Caln::convert($item, $level);
                $output .= $_convert;
            }
        }

        return $output;
    }
}