familytree365 / php-gedcom

src/Writer/ObjeRef.php

<?php
/**
 * php-gedcom.
 *
 * php-gedcom is a library for parsing, manipulating, importing and exporting
 * GEDCOM 5.5 files in PHP 5.3+.
 *
 * @author          Xiang Ming <wenqiangliu344@gmail.com>
 * @copyright       Copyright (c) 2010-2013, Xiang Ming
 * @license         MIT
 *
 * @link            http://github.com/mrkrstphr/php-gedcom
 */

namespace Gedcom\Writer;

class ObjeRef
{
    /**
     * @param \Gedcom\Record\ObjeRef $note
     * @param int                    $level
     *
     * @return string
     */
    public static function convert(\Gedcom\Record\ObjeRef &$obje, $level)
    {
        $output = '';

        // $_note
        $_obje = $obje->getObje();

The method getObje() does not exist on Gedcom\Record\ObjeRef. Since you implemented __call, consider adding a @method annotation.

        if (!empty($_note)) {

The variable $_note seems to never exist and therefore empty should always be true.

            $output .= $level.' OBJE '.$_obje."\n";

Are you sure $_obje of type Gedcom\Record\ObjeRef|mixed|null can be used in concatenation?

        } else {
            $output .= $level." OBJE \n";
        }

        $level++;
        // _form
        $_form = $obje->getForm();

The method getForm() does not exist on Gedcom\Record\ObjeRef. Since you implemented __call, consider adding a @method annotation.

        if (!empty($_form)) {
            $output .= $level.' FORM '.$_form."\n";

Are you sure $_form of type Gedcom\Record\ObjeRef|mixed can be used in concatenation?

        }

        // _titl
        $_titl = $obje->getTitl();

The method getTitl() does not exist on Gedcom\Record\ObjeRef. Since you implemented __call, consider adding a @method annotation.

        if (!empty($_titl)) {
            $output .= $level.' TITL '.$_titl."\n";

Are you sure $_titl of type Gedcom\Record\ObjeRef|mixed can be used in concatenation?

        }

        // _file
        $_file = $obje->getFile();

The method getFile() does not exist on Gedcom\Record\ObjeRef. Since you implemented __call, consider adding a @method annotation.

        if (!empty($_file)) {
            $output .= $level.' FILE '.$_file."\n";

Are you sure $_file of type Gedcom\Record\ObjeRef|mixed can be used in concatenation?

        }

        // $_note = array()
        $_note = $obje->getNote();

The method getNote() does not exist on Gedcom\Record\ObjeRef. Since you implemented __call, consider adding a @method annotation.

        if (!empty($_note) && count($_note) > 0) {

It seems like $_note can also be of type Gedcom\Record\ObjeRef; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

            foreach ($_note as $item) {
                $_convert = \Gedcom\Writer\NoteRef::convert($item, $level);
                $output .= $_convert;
            }
        }

        return $output;
    }
}