familytree365 / php-gedcom

src/Writer/Obje.php

<?php
/**
 * php-gedcom.
 *
 * php-gedcom is a library for parsing, manipulating, importing and exporting
 * GEDCOM 5.5 files in PHP 5.3+.
 *
 * @author          Xiang Ming <wenqiangliu344@gmail.com>
 * @copyright       Copyright (c) 2010-2013, Xiang Ming
 * @license         MIT
 *
 * @link            http://github.com/mrkrstphr/php-gedcom
 */

namespace Gedcom\Writer;

class Obje
{
    /**
     * @param \Gedcom\Record\Obje $sour
     * @param int                 $level
     *
     * @return string
     */
    public static function convert(\Gedcom\Record\Obje &$obje)
    {
        $level = 0;
        $output = '';
        $id = $obje->getId();

The method getId() does not exist on Gedcom\Record\Obje. Since you implemented __call, consider adding a @method annotation.

        if ($id) {
            $output .= $level.' '.$id." OBJE\n";

Are you sure $id of type Gedcom\Record\Obje|mixed can be used in concatenation?

        } else {
            return $output;
        }

        // level up
        $level++;

        // FORM
        $form = $obje->getName();

The method getName() does not exist on Gedcom\Record\Obje. Since you implemented __call, consider adding a @method annotation.

        if ($form) {
            $output .= $level.' FORM '.$form."\n";

Are you sure $form of type Gedcom\Record\Obje|mixed can be used in concatenation?

        }

        // TITL
        $titl = $obje->getTitl();

The method getTitl() does not exist on Gedcom\Record\Obje. Since you implemented __call, consider adding a @method annotation.

        if ($titl) {
            $output .= $level.' TITL '.$titl."\n";

Are you sure $titl of type Gedcom\Record\Obje|mixed can be used in concatenation?

        }

        // OBJE
        // This is same as FORM

        // RIN
        $rin = $obje->getRin();

The method getRin() does not exist on Gedcom\Record\Obje. Since you implemented __call, consider adding a @method annotation.

        if ($rin) {
            $output .= $level.' RIN '.$rin."\n";

Are you sure $rin of type Gedcom\Record\Obje|mixed can be used in concatenation?

        }

        // REFN
        $refn = $obje->getRefn();

The method getRefn() does not exist on Gedcom\Record\Obje. Since you implemented __call, consider adding a @method annotation.

        if (!empty($refn) && count($refn) > 0) {

It seems like $refn can also be of type Gedcom\Record\Obje; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

            foreach ($refn as $item) {
                if ($item) {
                    $_convert = \Gedcom\Writer\Refn::convert($item, $level);
                    $output .= $_convert;
                }
            }
        }

        // BLOB
        $blob = $obje->getBlob();

The method getBlob() does not exist on Gedcom\Record\Obje. Since you implemented __call, consider adding a @method annotation.

        if ($blob) {
            $output .= $level.' BLOB '.$blob."\n";

Are you sure $blob of type Gedcom\Record\Obje|mixed can be used in concatenation?

        }

        // NOTE
        $note = $obje->getNote();

The method getNote() does not exist on Gedcom\Record\Obje. Since you implemented __call, consider adding a @method annotation.

        if ($note && count($note) > 0) {
            foreach ($note as $item) {
                if ($item) {
                    $_convert = \Gedcom\Writer\NoteRef::convert($item, $level);
                    $output .= $_convert;
                }
            }
        }

        // CHAN
        $chan = $obje->getChan();

The method getChan() does not exist on Gedcom\Record\Obje. Since you implemented __call, consider adding a @method annotation.

        if ($chan) {
            $_convert = \Gedcom\Writer\Chan::convert($chan, $level);

It seems like $chan can also be of type Gedcom\Record\Obje; however, parameter $chan of Gedcom\Writer\Chan::convert() does only seem to accept Gedcom\Record\Chan, maybe add an additional type check?

            $output .= $_convert;
        }

        // FILE
        $file = $obje->getFile();

The method getFile() does not exist on Gedcom\Record\Obje. Since you implemented __call, consider adding a @method annotation.

        if ($file) {
            $output .= $level.' FILE '.$file."\n";

Are you sure $file of type Gedcom\Record\Obje|mixed can be used in concatenation?

        }

        //
        return $output;
    }
}