familytree365 / php-gedcom

src/Writer/Note.php

<?php
/**
 * php-gedcom.
 *
 * php-gedcom is a library for parsing, manipulating, importing and exporting
 * GEDCOM 5.5 files in PHP 5.3+.
 *
 * @author          Kristopher Wilson <kristopherwilson@gmail.com>
 * @copyright       Copyright (c) 2010-2013, Kristopher Wilson
 * @license         MIT
 *
 * @link            http://github.com/mrkrstphr/php-gedcom
 */

namespace Gedcom\Writer;

class Note
{
    /**
     * @param \Gedcom\Record\Note $sour
     * @param int                 $level
     *
     * @return string
     */
    public static function convert(\Gedcom\Record\Note &$note)
    {
        $level = 0;
        $output = '';
        $id = $note->getId();

The method getId() does not exist on Gedcom\Record\Note. Since you implemented __call, consider adding a @method annotation.

        if (!empty($id)) {
            $output .= $level.' '.$id.' '." NOTE \n";

Are you sure $id of type Gedcom\Record\Note|mixed can be used in concatenation?

        } else {
            return $output;
        }

        // Level Up
        $level++;
        // RIN
        $rin = $note->getRin();

The method getRin() does not exist on Gedcom\Record\Note. Since you implemented __call, consider adding a @method annotation.

        if ($rin) {
            $output .= $level.' RIN '.$rin."\n";

Are you sure $rin of type Gedcom\Record\Note|mixed can be used in concatenation?

        }

        // cont
        $cont = $note->getNote();

The method getNote() does not exist on Gedcom\Record\Note. Since you implemented __call, consider adding a @method annotation.

        if ($cont) {
            $output .= $level.' CONT '.$cont."\n";

Are you sure $cont of type Gedcom\Record\Note|mixed can be used in concatenation?

        }

        // REFN
        $refn = $note->getRefn();

The method getRefn() does not exist on Gedcom\Record\Note. Since you implemented __call, consider adding a @method annotation.

        if (!empty($refn) && count($refn) > 0) {

It seems like $refn can also be of type Gedcom\Record\Note; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

            foreach ($refn as $item) {
                if ($item) {
                    $_convert = \Gedcom\Writer\Refn::convert($item, $level);
                    $output .= $_convert;
                }
            }
        }
        // CHAN
        $chan = $note->getChan();

The method getChan() does not exist on Gedcom\Record\Note. Since you implemented __call, consider adding a @method annotation.

        if ($chan) {
            $_convert = \Gedcom\Writer\Chan::convert($chan, $level);

It seems like $chan can also be of type Gedcom\Record\Note; however, parameter $chan of Gedcom\Writer\Chan::convert() does only seem to accept Gedcom\Record\Chan, maybe add an additional type check?

            $output .= $_convert;
        }

        // SOUR array
        $sour = $note->getSour();

The method getSour() does not exist on Gedcom\Record\Note. Since you implemented __call, consider adding a @method annotation.

        if (!empty($sour) && count($sour) > 0) {
            foreach ($sour as $item) {
                if ($item) {
                    $_convert = \Gedcom\Writer\SourRef::convert($item, $level);
                    $output .= $_convert;
                }
            }
        }

        return $output;
    }
}