familytree365 / php-gedcom

src/Writer/Indi/Asso.php

<?php
/**
 * php-gedcom.
 *
 * php-gedcom is a library for parsing, manipulating, importing and exporting
 * GEDCOM 5.5 files in PHP 5.3+.
 *
 * @author          Xiang Ming <wenqiangliu344@gmail.com>
 * @copyright       Copyright (c) 2010-2013, Xiang Ming
 * @license         MIT
 *
 * @link            http://github.com/mrkrstphr/php-gedcom
 */

namespace Gedcom\Writer\Indi;

class Asso
{
    /**
     * @param \Gedcom\Record\Indi\Asso $attr
     * @param int                      $level
     *
     * @return string
     */
    public static function convert(\Gedcom\Record\Indi\Asso &$asso, $level = 0)
    {
        $output = '';
        // _indi
        $_indi = $asso->getIndi();

The method getIndi() does not exist on Gedcom\Record\Indi\Asso. Since you implemented __call, consider adding a @method annotation.

        if (empty($_indi)) {
            return $output;
        }
        $output .= $level.' ASSO '.$_indi."\n";

Are you sure $_indi of type Gedcom\Record\Indi\Asso|mixed can be used in concatenation?

        // level up
        $level++;

        // RELA
        $rela = $asso->getRela();

The method getRela() does not exist on Gedcom\Record\Indi\Asso. Since you implemented __call, consider adding a @method annotation.

        if (!empty($rela)) {
            $output .= $level.' RELA '.$rela."\n";

Are you sure $rela of type Gedcom\Record\Indi\Asso|mixed can be used in concatenation?

        }
        // sour
        $sour = $asso->getSour();

The method getSour() does not exist on Gedcom\Record\Indi\Asso. Since you implemented __call, consider adding a @method annotation.

        if (!empty($sour) && count($sour) > 0) {

It seems like $sour can also be of type Gedcom\Record\Indi\Asso; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

            foreach ($sour as $item) {
                $_convert = \Gedcom\Writer\SourRef::convert($item, $level);
                $output .= $_convert;
            }
        }

        // note
        $note = $asso->getSour();
        if (!empty($note) && count($note) > 0) {
            foreach ($note as $item) {
                $_convert = \Gedcom\Writer\NoteRef::convert($item, $level);
                $output .= $_convert;
            }
        }

        return $output;
    }
}