familytree365 / php-gedcom

src/Writer/Head/Sour.php

<?php
/**
 * php-gedcom.
 *
 * php-gedcom is a library for parsing, manipulating, importing and exporting
 * GEDCOM 5.5 files in PHP 5.3+.
 *
 * @author          Xiang Ming <wenqiangliu344@gmail.com>
 * @copyright       Copyright (c) 2010-2013, Xiang Ming
 * @license         MIT
 *
 * @link            http://github.com/mrkrstphr/php-gedcom
 */

namespace Gedcom\Writer\Head;

class Sour
{
    /**
     * @param string $format
     * @param int    $level
     *
     * @return string
     */
    public static function convert(\Gedcom\Record\Head\Sour &$sour, $level)
    {
        $output = '';
        $_sour = $sour->getSour();

The method getSour() does not exist on Gedcom\Record\Head\Sour. Since you implemented __call, consider adding a @method annotation.

        if ($_sour) {
            $output .= $level.' SOUR '.$_sour."\n";

Are you sure $_sour of type Gedcom\Record\Head\Sour|mixed can be used in concatenation?

        } else {
            return $output;
        }

        // level up
        $level++;

        // VERS
        $vers = $sour->getVersion();
        if ($vers) {

$vers is of type Gedcom\Record\Head\Sour\Version, thus it always evaluated to true.

            $output .= $level.' VERS '.$vers."\n";
        }

        // NAME
        $name = $sour->getName();
        if ($name) {

$name is of type Gedcom\Record\Head\Sour\Name, thus it always evaluated to true.

            $output .= $level.' NAME '.$name."\n";
        }

        // CORP
        $corp = $sour->getCorp();
        if ($corp) {

$corp is of type Gedcom\Record\Head\Sour\Corp, thus it always evaluated to true.

            $_convert = \Gedcom\Writer\Head\Sour\Corp::convert($corp, $level);
            $output .= $_convert;
        }

        // DATA
        $data = $sour->getData();
        if ($data) {

$data is of type Gedcom\Record\Head\Sour\Data, thus it always evaluated to true.

            $_convert = \Gedcom\Writer\Head\Sour\Data::convert($data, $level);
            $output .= $_convert;
        }

        return $output;
    }
}