familytree365 / php-gedcom

src/Parser/NoteRef.php

<?php
/**
 * php-gedcom.
 *
 * php-gedcom is a library for parsing, manipulating, importing and exporting
 * GEDCOM 5.5 files in PHP 5.3+.
 *
 * @author          Kristopher Wilson <kristopherwilson@gmail.com>
 * @copyright       Copyright (c) 2010-2013, Kristopher Wilson
 * @license         MIT
 *
 * @link            http://github.com/mrkrstphr/php-gedcom
 */

namespace Gedcom\Parser;

class NoteRef extends \Gedcom\Parser\Component
{
    public static function parse(\Gedcom\Parser $parser)
    {
        $record = $parser->getCurrentLineRecord();
        $depth = (int) $record[0];

        $note = new \Gedcom\Record\NoteRef();

        if (count($record) < 3) {

It seems like $record can also be of type false; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

            $parser->logSkippedRecord('Missing note information; '.self::class, ' @ '.__LINE__);

The call to Gedcom\Parser::logSkippedRecord() has too many arguments starting with ' @ ' . __LINE__.

            $parser->skipToNextLevel($depth);

            return null;
        }

        if (preg_match('/^@(.*)@$/', trim($record[2]))) {
            $note->setIsReference(true);
            $note->setNote($parser->normalizeIdentifier($record[2]));

The method setNote() does not exist on Gedcom\Record\NoteRef. Since you implemented __call, consider adding a @method annotation.

        } else {
            $parser->getCurrentLine();
            $note->setIsReference(false);
            $note->setNote($parser->parseMultiLineRecord());
        }

        $parser->forward();

        while (!$parser->eof()) {
            $record = $parser->getCurrentLineRecord();
            $recordType = strtoupper(trim($record[1]));
            $currentDepth = (int) $record[0];

            if ($currentDepth <= $depth) {
                $parser->back();
                break;
            }

            switch ($recordType) {
                case 'SOUR':
                    $sour = \Gedcom\Parser\SourRef::parse($parser);
                    $note->addSour($sour);
                    break;
                default:
                    $parser->logUnhandledRecord(self::class.' @ '.__LINE__);
            }

            $parser->forward();
        }

        return $note;
    }
}