familytree365 / php-gedcom

src/Parser/Note.php

<?php
/**
 * php-gedcom.
 *
 * php-gedcom is a library for parsing, manipulating, importing and exporting
 * GEDCOM 5.5 files in PHP 5.3+.
 *
 * @author          Kristopher Wilson <kristopherwilson@gmail.com>
 * @copyright       Copyright (c) 2010-2013, Kristopher Wilson
 * @license         MIT
 *
 * @link            http://github.com/mrkrstphr/php-gedcom
 */

namespace Gedcom\Parser;

class Note extends \Gedcom\Parser\Component
{
    public static function parse(\Gedcom\Parser $parser)
    {
        $record = $parser->getCurrentLineRecord(4);
        $depth = (int) $record[0];
        if (isset($record[1])) {
            $identifier = $parser->normalizeIdentifier($record[1]);
        } else {
            $parser->skipToNextLevel($depth);

            return null;
        }

        $note = new \Gedcom\Record\Note();
        $note->setId($identifier);

The method setId() does not exist on Gedcom\Record\Note. Since you implemented __call, consider adding a @method annotation.

        if (isset($record[3])) {
            $note->setNote($record[3]);

The method setNote() does not exist on Gedcom\Record\Note. Since you implemented __call, consider adding a @method annotation.

        }

        $parser->forward();

        while (!$parser->eof()) {
            $record = $parser->getCurrentLineRecord();
            $currentDepth = (int) $record[0];
            $recordType = strtoupper(trim($record[1]));

            if ($currentDepth <= $depth) {
                $parser->back();
                break;
            }

            switch ($recordType) {
                case 'CONT':
                    $note->setNote($note->getNote()."\n");

Are you sure $note->getNote() of type Gedcom\Record\Note|mixed|null can be used in concatenation?

The method getNote() does not exist on Gedcom\Record\Note. Since you implemented __call, consider adding a @method annotation.

                    if (isset($record[2])) {
                        $note->setNote($note->getNote().$record[2]);
                    }
                    break;
                case 'CONC':
                    if (isset($record[2])) {
                        $note->setNote($note->getNote().$record[2]);
                    }
                    break;
                case 'REFN':
                    $refn = \Gedcom\Parser\Refn::parse($parser);
                    $note->addRefn($refn);
                    break;
                case 'RIN':
                    $note->setRin(trim($record[2]));

The method setRin() does not exist on Gedcom\Record\Note. Since you implemented __call, consider adding a @method annotation.

                    break;
                case 'SOUR':
                    $sour = \Gedcom\Parser\SourRef::parse($parser);
                    $note->addSour($sour);
                    break;
                case 'CHAN':
                    $chan = \Gedcom\Parser\Chan::parse($parser);
                    $note->setChan($chan);

The method setChan() does not exist on Gedcom\Record\Note. Since you implemented __call, consider adding a @method annotation.

                    break;
                default:
                    $parser->logUnhandledRecord(self::class.' @ '.__LINE__);
            }

            $parser->forward();
        }
        $parser->getGedcom()->addNote($note);

        return $note;
    }
}