Gedcom\Writer\NoteRef::convert()

Complexity

Conditions	5
Paths	4

Size

Total Lines	21
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function convert(\Gedcom\Record\NoteRef &$note, $level)
    {
        $output = '';

        // $_note
        $_note = $note->getNote();

The method getNote() does not exist on Gedcom\Record\NoteRef. Since you implemented __call, consider adding a @method annotation.

        if (!empty($_note)) {
            $output .= $level.' NOTE '.$_note."\n";

Are you sure $_note of type Gedcom\Record\NoteRef|mixed can be used in concatenation?

        }

        $level++;
        // $sour
        $sour = $note->getSour();

The method getSour() does not exist on Gedcom\Record\NoteRef. Since you implemented __call, consider adding a @method annotation.

        if ($sour && count($sour) > 0) {

It seems like $sour can also be of type Gedcom\Record\NoteRef; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

            foreach ($sour as $item) {
                $_convert = \Gedcom\Writer\SourRef::convert($item, $level);
                $output .= $_convert;
            }
        }

        return $output;
    }