FamilyTree365\LaravelGedcom\Utils\Exporter\SourRef::read()

Complexity

Conditions	11
Paths	18

Size

Total Lines	55
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function read($conn, \Gedcom\Record\SourRef $sourref, $group = '', $group_id = 0, $sour_ids = [], $obje_ids = [])
    {
        if ($sourref == null) {
            return;
        }

        $sour = $sourref->getSour();
        if (!isset($sour_ids[$sour])) {
            return;
        }
        $sour_id = $sour_ids[$sour];
        $text = $sourref->getText();
        $quay = $sourref->getQuay();
        $page = $sourref->getPage();

        // store Source
        $key = ['group'=>$group, 'gid'=>$group_id, 'sour_id'=>$sour_id];
        $data = [
            'group'  => $group,
            'gid'    => $group_id,
            'sour_id'=> $sour_id,
            'text'   => $text,
            'quay'   => $quay,
            'page'   => $page,
        ];
        $record = SourceRef::on($conn)->updateOrCreate($key, $data);

        $_group = 'sourref';
        $_gid = $record->id;
        // store MediaObje
        $objes = $sourref->getObje();
        if ($objes && count($objes) > 0) {

It seems like $objes can also be of type Gedcom\Record\SourRef; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

            foreach ($objes as $item) {
                ObjeRef::read($conn, $item, $_group, $_gid, $obje_ids);
            }
        }

        // store Note
        $notes = $sourref->getNote();
        if ($notes && count($notes) > 0) {
            foreach ($notes as $item) {
                NoteRef::read($conn, $item, $_group, $_gid);
            }
        }

        // store Data
        $data = $sourref->getData();
        if ($data) {
            Data::read($conn, $data, $_group, $_gid);

It seems like $data can also be of type Gedcom\Record\SourRef; however, parameter $data of FamilyTree365\LaravelGedcom\Utils\Importer\Sour\Data::read() does only seem to accept Gedcom\Record\Sour\Data, maybe add an additional type check?

        }

        // store \Gedcom\Record\SourRef\Even
        $even = $sourref->getEven();
        if ($even) {
            Even::read($conn, $even, $_group, $_gid);

It seems like $even can also be of type Gedcom\Record\SourRef; however, parameter $even of FamilyTree365\LaravelGedcom\Utils\Importer\SourRef\Even::read() does only seem to accept Gedcom\Record\SourRef\Even, maybe add an additional type check?

        }