FamilyTree365\LaravelGedcom\Utils\Exporter\Obje::read()

Complexity

Conditions	13
Paths	17

Size

Total Lines	57
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function read($conn, \Gedcom\Record\Obje $obje, $group = '', $group_id = 0)
    {
        if ($obje == null) {
            return 0;
        }

        $id = $obje->getId();
        $rin = $obje->getRin(); // string

        // store Object
        $key = [
            'group'   => $group,
            'gid'     => $group_id,
            'rin'     => $rin,
            'obje_id' => $id,
        ];
        $data = [
            'group'   => $group,
            'gid'     => $group_id,
            'rin'     => $rin,
            'obje_id' => $id,
        ];

        $record = MediaObject::on($conn)->updateOrCreate($key, $data);

        $_group = 'obje';
        $_gid = $record->id;

        $refn = $obje->getRefn(); // Record/Refn array
        if ($refn && count($refn) > 0) {

It seems like $refn can also be of type Gedcom\Record\Obje; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

            foreach ($refn as $item) {
                Refn::read($conn, $item, $_group, $_gid);
            }
        }

        // store Note
        $note = $obje->getNote(); // Record/NoteRef array
        if ($note && count($note) > 0) {
            foreach ($note as $item) {
                NoteRef::read($conn, $item, $_group, $_gid);
            }
        }

        // store Note
        $files = $obje->getFile(); // Record/NoteRef array
        if (($files && count((is_countable($files) ? $files : [])))) {
            foreach ($files as $item) {
                \FamilyTree365\LaravelGedcom\Utils\Importer\ObjeRef\File::read($conn, $item, $_group, $_gid);
            }
        }

        $chan = $obje->getChan(); // Recore/Chan
        if ($chan !== null) {
            \FamilyTree365\LaravelGedcom\Utils\Importer\Chan::read($conn, $chan, $_group, $_gid);

It seems like $chan can also be of type Gedcom\Record\Obje; however, parameter $chan of FamilyTree365\LaravelGedcom\Utils\Importer\Chan::read() does only seem to accept Gedcom\Record\Chan, maybe add an additional type check?

        }

        return $_gid;
    }