FamilyTree365\LaravelGedcom\Utils\Exporter\Note::read()

Complexity

Conditions	9
Paths	53

Size

Total Lines	41
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function read($conn, \Gedcom\Record\Note $note, $group = '', $group_id = 0)
    {
       try
       {
             $_note = $note->getNote();
            $rin = $note->getRin();

            // store note
            $key = ['group'=>$group, 'gid'=>$group_id, 'note'=> utf8_encode($_note) ];

It seems like $_note can also be of type Gedcom\Record\Note and null; however, parameter $string of utf8_encode() does only seem to accept string, maybe add an additional type check?

            $data = ['group'=>$group, 'gid'=>$group_id, 'note'=> utf8_encode($_note), 'rin'=>$rin];
            $record = MNote::on($conn)->updateOrCreate($key, $data);

            // store Sources of Note
            $_group = 'note';
            $_gid = $record->id;
            // SourRef array
            $sour = $note->getSour();
            if ($sour && count($sour) > 0) {

It seems like $sour can also be of type Gedcom\Record\Note; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

                foreach ($sour as $item) {
                    SourRef::read($conn, $item, $_group, $_gid);
                }
            }
            // Refn array
            $refn = $note->getRefn();
            if ($refn && count($refn) > 0) {
                foreach ($refn as $item) {
                    Refn::read($conn, $item, $_group, $_gid);
                }
            }

            // Chan
            $chan = $note->getChan();
            if ($chan !== null) {
                Chan::read($conn, $chan, $_group, $_gid);

It seems like $chan can also be of type Gedcom\Record\Note; however, parameter $chan of FamilyTree365\LaravelGedcom\Utils\Exporter\Chan::read() does only seem to accept Gedcom\Record\Chan, maybe add an additional type check?

            }

            return $_gid;
       }
       catch(Throwable $e)
       {
        report($e);

The function report was not found. Maybe you did not declare it correctly or list all dependencies?

       }