FamilyTree365\LaravelGedcom\Utils\Exporter\Indi\Asso::read()

Complexity

Conditions	9
Paths	8

Size

Total Lines	29
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function read($conn, \Gedcom\Record\Indi\Asso $asso, $group = '', $group_id = 0)
    {
        $indi = $group_id;

The assignment to $indi is dead and can be removed.

        $_indi = $asso->getIndi();
        $rela = $asso->getRela();

        // store asso
        $key = ['group'=>$group, 'gid'=>$group_id, 'rela'=>$rela, 'indi' => $_indi];
        $data = ['group'=>$group, 'gid'=>$group_id, 'rela'=>$rela, 'indi' => $_indi];
        $record = PersonAsso::on($conn)->updateOrCreate($key, $data);

        $_group = 'indi_asso';
        $_gid = $record->id;
        // store Note
        $note = $asso->getNote();
        if ($note && count($note) > 0) {

It seems like $note can also be of type Gedcom\Record\Indi\Asso; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

            foreach ($note as $item) {
                if ($item) {
                    \FamilyTree365\LaravelGedcom\Utils\Importer\NoteRef::read($conn, $item, $_group, $_gid);
                }
            }
        }

        // store sourref
        $sour = $asso->getSour();
        if ($sour && count($sour) > 0) {
            foreach ($sour as $item) {
                if ($item) {
                    \FamilyTree365\LaravelGedcom\Utils\Importer\SourRef::read($conn, $item, $_group, $_gid);
                }