FamilyTree365\LaravelGedcom\Utils\Exporter\Chan

Complexity

Total Complexity

5

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	read()	0	19	5

<?php

namespace FamilyTree365\LaravelGedcom\Utils\Exporter;

use FamilyTree365\LaravelGedcom\Models\Chan as MChan;

class Chan
{
    /**
     * Gedcom\Record\Chan $chan
     * String $group
     * Integer $group_id.
     */
    public static function read($conn, \Gedcom\Record\Chan $chan, $group = '', $group_id = 0)
    {
        $date = $chan->getDate();
        $time = $chan->getTime();

        // store chan
        $key = ['group'=>$group, 'gid'=>$group_id, 'date'=>$date, 'time'=>$time];
        $data = ['group'=>$group, 'gid'=>$group_id,  'date'=>$date, 'time'=>$time];
        $record = MChan::on($conn)->updateOrCreate($key, $data);

        // store Sources of Note
        $_group = 'chan';
        $_gid = $record->id;
        // SourRef array
        $note = $chan->getNote();
        if ($note && count($note) > 0) {

The expression $note of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($note as $item) {
                if ($item) {
                    NoteRef::read($conn, $item, $_group, $_gid);
                }
            }
        }
    }
}