FamilyTree365\LaravelGedcom\Utils\Importer\RepoRef::read()

Complexity

Conditions	9
Paths	9

Size

Total Lines	31
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function read($conn, \Gedcom\Record\RepoRef $reporef, $group = '', $group_id = 0)
    {
        if ($reporef == null) {
            return;
        }
        $repo = $reporef->getRepo();
        // store Source
        $key = ['group'=>$group, 'gid'=>$group_id, 'repo' => $repo];
        $data = [
            'group'=> $group,
            'gid'  => $group_id,
            'repo' => $repo,
        ];
        $record = Repository::on($conn)->updateOrCreate($key, $data);

        $_group = 'reporef';
        $_gid = $record->id;
        // store Note
        $notes = $reporef->getNote();
        if ($notes && count($notes) > 0) {

It seems like $notes can also be of type Gedcom\Record\RepoRef; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

            foreach ($notes as $item) {
                NoteRef::read($conn, $item, $_group, $_gid);
            }
        }

        // store Caln
        $caln = $reporef->getCaln();
        if ($caln && count($caln) > 0) {
            foreach ($caln as $item) {
                if ($item) {
                    Caln::read($conn, $item, $_group, $_gid);
                }