familytree365 /
laravel-gedcom
| Conditions | 65 |
| Paths | > 20000 |
| Total Lines | 188 |
| Code Lines | 148 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 186 | public static function otherField($conn, $events, $person) |
||
| 187 | { |
||
| 188 | try |
||
| 189 | { |
||
| 190 | foreach ($events as $event) { |
||
| 191 | |||
| 192 | if ($event && count($event) > 0) { |
||
| 193 | $even = $event[0]; |
||
| 194 | $class_name = get_class($even); |
||
| 195 | $person_id = $person->id; |
||
| 196 | $type = $even->getType(); |
||
| 197 | $attr = $even->getAttr(); |
||
| 198 | $_date = $even->getDate(); |
||
| 199 | $date = \FamilyTree365\LaravelGedcom\Utils\Importer\Date::read($conn, $_date); |
||
| 200 | $_plac = $even->getPlac(); |
||
| 201 | $plac = \FamilyTree365\LaravelGedcom\Utils\Importer\Indi\Even\Plac::read($conn, $_plac); |
||
| 202 | $_phon = $even->getPhon(); |
||
| 203 | $phon = \FamilyTree365\LaravelGedcom\Utils\Importer\Phon::read($conn, $_phon); |
||
| 204 | $_addr = $even->getAddr(); |
||
| 205 | //$addr_id = \FamilyTree365\LaravelGedcom\Utils\Importer\Addr::read($conn, $_addr); |
||
| 206 | if (!empty($_addr)) { |
||
| 207 | $addr_id = \FamilyTree365\LaravelGedcom\Utils\Importer\Addr::read($conn, $_addr); |
||
| 208 | } else { |
||
| 209 | $addr_id = null; |
||
| 210 | } |
||
| 211 | |||
| 212 | $caus = $even->getCaus(); |
||
| 213 | $age = $even->getAge(); |
||
| 214 | $agnc = $even->getAgnc(); |
||
| 215 | $adop = ''; |
||
| 216 | $adop_famc = ''; |
||
| 217 | $birt_famc = ''; |
||
| 218 | switch ($class_name) { |
||
| 219 | case 'Adop': |
||
| 220 | $adop = $even->getAdop(); |
||
| 221 | $adop_famc = $even->getFamc(); |
||
| 222 | break; |
||
| 223 | case 'Birt': |
||
| 224 | $birt_famc = $even->getFamc(); |
||
| 225 | break; |
||
| 226 | case 'Bapm': |
||
| 227 | break; |
||
| 228 | case 'Barm': |
||
| 229 | break; |
||
| 230 | case 'Basm': |
||
| 231 | break; |
||
| 232 | case 'Bles': |
||
| 233 | break; |
||
| 234 | case 'Buri': |
||
| 235 | break; |
||
| 236 | case 'Cast': |
||
| 237 | break; |
||
| 238 | case 'Cens': |
||
| 239 | break; |
||
| 240 | case 'Chr': |
||
| 241 | $chr_famc = $even->getFamc(); |
||
| 242 | break; |
||
| 243 | case 'Chra': |
||
| 244 | break; |
||
| 245 | case 'Conf': |
||
| 246 | break; |
||
| 247 | case 'Crem': |
||
| 248 | break; |
||
| 249 | case 'Dscr': |
||
| 250 | break; |
||
| 251 | case 'Deat': |
||
| 252 | break; |
||
| 253 | case 'Educ': |
||
| 254 | break; |
||
| 255 | case 'Emig': |
||
| 256 | break; |
||
| 257 | case 'Fcom': |
||
| 258 | break; |
||
| 259 | case 'Grad': |
||
| 260 | break; |
||
| 261 | case 'Idno': |
||
| 262 | break; |
||
| 263 | case 'Immi': |
||
| 264 | break; |
||
| 265 | case 'Nati': |
||
| 266 | break; |
||
| 267 | case 'Nchi': |
||
| 268 | break; |
||
| 269 | case 'Natu': |
||
| 270 | break; |
||
| 271 | case 'Nmr': |
||
| 272 | break; |
||
| 273 | case 'Occu': |
||
| 274 | break; |
||
| 275 | case 'Ordn': |
||
| 276 | break; |
||
| 277 | case 'Reti': |
||
| 278 | break; |
||
| 279 | case 'Prob': |
||
| 280 | break; |
||
| 281 | case 'Prop': |
||
| 282 | break; |
||
| 283 | case 'Reli': |
||
| 284 | break; |
||
| 285 | case 'Resi': |
||
| 286 | break; |
||
| 287 | case 'Ssn': |
||
| 288 | break; |
||
| 289 | case 'Titl': |
||
| 290 | break; |
||
| 291 | case 'Will': |
||
| 292 | break; |
||
| 293 | case 'Even': |
||
| 294 | break; |
||
| 295 | default: |
||
| 296 | } |
||
| 297 | $adop = ''; |
||
| 298 | $adop_famc = ''; |
||
| 299 | $birt_famc = ''; |
||
| 300 | // store Even |
||
| 301 | $key = [ |
||
| 302 | ['person_id', $person_id], |
||
| 303 | ['title', $class_name], |
||
| 304 | ['type', $type], |
||
| 305 | ['attr', $attr], |
||
| 306 | ['date', $date], |
||
| 307 | ['plac', $plac], |
||
| 308 | ['phon', $phon], |
||
| 309 | ['caus', $caus], |
||
| 310 | ['age', $age], |
||
| 311 | ['agnc', $agnc], |
||
| 312 | ['adop', $adop], |
||
| 313 | ['adop_famc', $adop_famc], |
||
| 314 | ['birt_famc', $birt_famc], |
||
| 315 | ]; |
||
| 316 | |||
| 317 | // update person's record |
||
| 318 | if ($class_name == 'BIRT' && !empty($date)) { |
||
| 319 | $person->birthday = date('Y-m-d', strtotime($date)); |
||
| 320 | } |
||
| 321 | // add deathyear to person table ( for form builder ) |
||
| 322 | if ($class_name == 'DEAT' && !empty($date)) { |
||
| 323 | $person->deathday = date('Y-m-d', strtotime($date)); |
||
| 324 | } |
||
| 325 | $person->save(); |
||
| 326 | |||
| 327 | $sour = $even->getSour(); |
||
| 328 | $notes = $even->getNote(); |
||
| 329 | $obje = $even->getObje(); |
||
| 330 | $_chan = $even->getChan() ?? null; |
||
| 331 | if ((!empty($sour) && count($sour) > 0) || (!empty($obje) && count($obje) > 0) || (!empty($notes) && count($notes) > 0) || !empty($_chan)) { |
||
| 332 | $record = PersonEvent::on($conn)->where($key)->first(); |
||
| 333 | $_group = 'indi_even'; |
||
| 334 | $_gid = $record->id; |
||
| 335 | } |
||
| 336 | |||
| 337 | // array |
||
| 338 | //$sour = $even->getSour(); |
||
| 339 | if ($sour && count($sour) > 0) { |
||
| 340 | foreach ($sour as $item) { |
||
| 341 | if ($item) { |
||
| 342 | \FamilyTree365\LaravelGedcom\Utils\Importer\SourRef::read($conn, $item, $_group, $_gid); |
||
| 343 | } |
||
| 344 | } |
||
| 345 | } |
||
| 346 | //$obje = $even->getObje(); |
||
| 347 | if ($obje && count($obje) > 0) { |
||
| 348 | foreach ($obje as $item) { |
||
| 349 | if ($item) { |
||
| 350 | \FamilyTree365\LaravelGedcom\Utils\Importer\ObjeRef::read($conn, $item, $_group, $_gid, $obje); |
||
| 351 | } |
||
| 352 | } |
||
| 353 | } |
||
| 354 | //$notes = $even->getNote(); |
||
| 355 | if ($notes && count($notes) > 0) { |
||
| 356 | foreach ($notes as $item) { |
||
| 357 | \FamilyTree365\LaravelGedcom\Utils\Importer\NoteRef::read($conn, $item, $_group, $_gid); |
||
| 358 | } |
||
| 359 | } |
||
| 360 | // object |
||
| 361 | //$_chan = $even->getChan() ?? null; |
||
| 362 | if ($_chan !== null) { |
||
| 363 | \FamilyTree365\LaravelGedcom\Utils\Importer\Chan::read($conn, $_chan, $_group, $_gid); |
||
| 364 | } |
||
| 365 | |||
| 366 | // $_type = $even->getType(); |
||
| 367 | // $person->addEvent($_type, $date, $plac); |
||
| 368 | } |
||
| 369 | } |
||
| 370 | } |
||
| 371 | catch(Throwable $e) |
||
| 372 | { |
||
| 373 | report($e); |
||
| 374 | } |
||
| 377 |
Loading history...
This check looks for parameters that have been defined for a function or method, but which are not used in the method body.