Conditions | 45 |
Paths | 447 |
Total Lines | 167 |
Code Lines | 151 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
17 | public static function read($conn, $events, $person, $obje_ids = []) |
||
|
|||
18 | { |
||
19 | |||
20 | if(empty($person)) return; |
||
21 | |||
22 | $eventData = []; |
||
23 | foreach ($events as $event) { |
||
24 | if ($event && count($event) > 0) { |
||
25 | $even = $event[0]; |
||
26 | $class_name = get_class($even); |
||
27 | $person_id = $person->id; |
||
28 | $type = $even->getType(); |
||
29 | $attr = $even->getAttr(); |
||
30 | $_date = $even->getDate(); |
||
31 | $date = \FamilyTree365\LaravelGedcom\Utils\Importer\Date::read($conn, $_date); |
||
32 | if (strpos($date, 'BEF') !== false) { |
||
33 | $newdate = trim(str_replace('BEF', '', $date)); |
||
34 | $date_cnvert = strtotime($newdate); |
||
35 | } elseif (strpos($date, 'AFT') !== false) { |
||
36 | $newdate = trim(str_replace('AFT', '', $date)); |
||
37 | $date_cnvert = strtotime($newdate); |
||
38 | } else { |
||
39 | $date_cnvert = strtotime($date); |
||
40 | } |
||
41 | $_plac = $even->getPlac(); |
||
42 | $plac = \FamilyTree365\LaravelGedcom\Utils\Importer\Indi\Even\Plac::read($conn, $_plac); |
||
43 | $_phon = $even->getPhon(); |
||
44 | $phon = \FamilyTree365\LaravelGedcom\Utils\Importer\Phon::read($conn, $_phon); |
||
45 | $_addr = $even->getAddr(); |
||
46 | //$addr_id = \FamilyTree365\LaravelGedcom\Utils\Importer\Addr::read($conn, $_addr); |
||
47 | if (!empty($_addr)) { |
||
48 | $addr_id = \FamilyTree365\LaravelGedcom\Utils\Importer\Addr::read($conn, $_addr); |
||
49 | } else { |
||
50 | $addr_id = null; |
||
51 | } |
||
52 | |||
53 | $caus = $even->getCaus(); |
||
54 | $age = $even->getAge(); |
||
55 | $agnc = $even->getAgnc(); |
||
56 | $adop = ''; |
||
57 | $adop_famc = ''; |
||
58 | $birt_famc = ''; |
||
59 | switch ($class_name) { |
||
60 | case 'Adop': |
||
61 | $adop = $even->getAdop(); |
||
62 | $adop_famc = $even->getFamc(); |
||
63 | break; |
||
64 | case 'Birt': |
||
65 | $birt_famc = $even->getFamc(); |
||
66 | break; |
||
67 | case 'Bapm': |
||
68 | break; |
||
69 | case 'Barm': |
||
70 | break; |
||
71 | case 'Basm': |
||
72 | break; |
||
73 | case 'Bles': |
||
74 | break; |
||
75 | case 'Buri': |
||
76 | break; |
||
77 | case 'Cast': |
||
78 | break; |
||
79 | case 'Cens': |
||
80 | break; |
||
81 | case 'Chr': |
||
82 | $chr_famc = $even->getFamc(); |
||
83 | break; |
||
84 | case 'Chra': |
||
85 | break; |
||
86 | case 'Conf': |
||
87 | break; |
||
88 | case 'Crem': |
||
89 | break; |
||
90 | case 'Dscr': |
||
91 | break; |
||
92 | case 'Deat': |
||
93 | break; |
||
94 | case 'Educ': |
||
95 | break; |
||
96 | case 'Emig': |
||
97 | break; |
||
98 | case 'Fcom': |
||
99 | break; |
||
100 | case 'Grad': |
||
101 | break; |
||
102 | case 'Idno': |
||
103 | break; |
||
104 | case 'Immi': |
||
105 | break; |
||
106 | case 'Nati': |
||
107 | break; |
||
108 | case 'Nchi': |
||
109 | break; |
||
110 | case 'Natu': |
||
111 | break; |
||
112 | case 'Nmr': |
||
113 | break; |
||
114 | case 'Occu': |
||
115 | break; |
||
116 | case 'Ordn': |
||
117 | break; |
||
118 | case 'Reti': |
||
119 | break; |
||
120 | case 'Prob': |
||
121 | break; |
||
122 | case 'Prop': |
||
123 | break; |
||
124 | case 'Reli': |
||
125 | break; |
||
126 | case 'Resi': |
||
127 | break; |
||
128 | case 'Ssn': |
||
129 | break; |
||
130 | case 'Titl': |
||
131 | break; |
||
132 | case 'Will': |
||
133 | break; |
||
134 | case 'Even': |
||
135 | break; |
||
136 | default: |
||
137 | } |
||
138 | $adop = ''; |
||
139 | $adop_famc = ''; |
||
140 | $birt_famc = ''; |
||
141 | // store Even |
||
142 | $key = [ |
||
143 | ['person_id', $person_id], |
||
144 | ['title', $class_name], |
||
145 | ['type', $type], |
||
146 | ['attr', $attr], |
||
147 | ['date', $date], |
||
148 | ['plac', $plac], |
||
149 | ['phon', $phon], |
||
150 | ['caus', $caus], |
||
151 | ['age', $age], |
||
152 | ['agnc', $agnc], |
||
153 | ['adop', $adop], |
||
154 | ['adop_famc', $adop_famc], |
||
155 | ['birt_famc', $birt_famc], |
||
156 | ]; |
||
157 | $check = PersonEvent::on($conn)->where($key)->first(); |
||
158 | if (empty($check)) { |
||
159 | $data = [ |
||
160 | 'person_id' => $person_id, |
||
161 | 'title' => $class_name, |
||
162 | 'type' => $type, // |
||
163 | 'attr' => $attr, // |
||
164 | 'date' => $date, |
||
165 | 'converted_date' => $date_cnvert, |
||
166 | 'plac' => $plac, // |
||
167 | 'addr_id' => $addr_id, // |
||
168 | 'phon' => $phon, // |
||
169 | 'caus' => $caus, // |
||
170 | 'age' => $age, // |
||
171 | 'agnc' => $agnc, // |
||
172 | 'adop' => $adop, // |
||
173 | 'adop_famc' => $adop_famc, // |
||
174 | 'birt_famc' => $birt_famc, // |
||
175 | ]; |
||
176 | |||
177 | $eventData[] = $data; |
||
178 | } |
||
179 | } |
||
180 | } |
||
181 | PersonEvent::on($conn)->insert($eventData); |
||
182 | $new = new Even(); |
||
183 | $new->otherField($conn, $events, $person); |
||
184 | } |
||
377 |
This check looks for parameters that have been defined for a function or method, but which are not used in the method body.