FamilyTree365\LaravelGedcom\Utils\Exporter\ObjeRef::read()

Complexity

Conditions	7
Paths	7

Size

Total Lines	30
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function read($conn, \Gedcom\Record\ObjeRef $objeref, $group = '', $group_id = 0, $obje_ids = [])
    {
        if ($objeref == null) {
            return;
        }
        $obje_id = $objeref->getObje();
        if (isset($obje_ids[$obje_id])) {
            $obje_id = $obje_ids[$obje_id];
        }
        $titl = $objeref->getTitl();
        $file = $objeref->getFile();

The assignment to $file is dead and can be removed.

        // store MediaObject
        $key = ['group'=>$group, 'gid'=>$group_id, 'titl'=>$titl];
        $data = [
            'group'  => $group,
            'gid'    => $group_id,
            'obje_id'=> $obje_id,
            'titl'   => $titl,
        ];
        $record = MediaObject::on($conn)->updateOrCreate($key, $data);

        $_group = 'objeref';
        $_gid = $record->id;
        // store Note

        $files = $objeref->getFile();
        if ($files && count((is_countable($files) ? $files : []))) {

It seems like is_countable($files) ? $files : array() can also be of type Gedcom\Record\ObjeRef; however, parameter $value of count() does only seem to accept Countable|array, maybe add an additional type check?

            foreach ($files as $item) {
                File::read($conn, $item, $_group, $_gid);
            }