FamilyTree365\LaravelGedcom\Utils\ParentData

Complexity

Total Complexity

21

Size/Duplication

Total Lines	175
Duplicated Lines	0 %

Importance

Changes	10
Bugs	3	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
F	getPerson()	0	150	19
A	validateDate()	0	5	2

<?php

namespace FamilyTree365\LaravelGedcom\Utils;

use Carbon\Carbon;

The type Carbon\Carbon was not found. Maybe you did not declare it correctly or list all dependencies?

use FamilyTree365\LaravelGedcom\Models\Family;
use FamilyTree365\LaravelGedcom\Models\Person;
use Illuminate\Support\Str;

The type Illuminate\Support\Str was not found. Maybe you did not declare it correctly or list all dependencies?

use Throwable;

class ParentData
{
    /**
     * Array of persons ID
     * key - old GEDCOM ID
     * value - new autoincrement ID.
     *
     * @var string
     */
    protected $persons_id = [];
    protected $subm_ids = [];
    protected $sour_ids = [];
    protected $obje_ids = [];
    protected $note_ids = [];
    protected $repo_ids = [];
    protected $conn = '';

    public static function getPerson($conn, $individuals, $obje_ids = [], $sour_ids = [])
    {
        $ParentData = [];

The assignment to $ParentData is dead and can be removed.

        $a = [];

The assignment to $a is dead and can be removed.

        try {
            foreach ($individuals as $k => $individual) {
                $g_id = $individual->getId();

The assignment to $g_id is dead and can be removed.

                $name = '';

The assignment to $name is dead and can be removed.

                $givn = '';

The assignment to $givn is dead and can be removed.

                $surn = '';

The assignment to $surn is dead and can be removed.

                $name = '';
                $npfx = '';
                $givn = '';
                $nick = '';
                $spfx = '';
                $surn = '';
                $nsfx = '';
                $type = '';
                $fone = null; // Gedcom/

The assignment to $fone is dead and can be removed.

                $romn = null;

The assignment to $romn is dead and can be removed.

                $names = $individual->getName();
                $attr = $individual->getAllAttr();
                $events = $individual->getAllEven();

The assignment to $events is dead and can be removed.

                $note = $individual->getNote();

The assignment to $note is dead and can be removed.

                $indv_sour = $individual->getSour();

The assignment to $indv_sour is dead and can be removed.

                $alia = $individual->getAlia(); // string array

The assignment to $alia is dead and can be removed.

                $asso = $individual->getAsso();

The assignment to $asso is dead and can be removed.

                $subm = $individual->getSubm();

The assignment to $subm is dead and can be removed.

                $anci = $individual->getAnci();

The assignment to $anci is dead and can be removed.

                $refn = $individual->getRefn();

The assignment to $refn is dead and can be removed.

                $obje = $individual->getObje();

The assignment to $obje is dead and can be removed.

                // object
                $bapl = $individual->getBapl();

The assignment to $bapl is dead and can be removed.

                $conl = $individual->getConl();

The assignment to $conl is dead and can be removed.

                $endl = $individual->getEndl();

The assignment to $endl is dead and can be removed.

                $slgc = $individual->getSlgc();

The assignment to $slgc is dead and can be removed.

                $chan = $individual->getChan();
                $g_id = $individual->getId();

                if (!empty($names)) {
                    $name = current($names)->getName() ?: '';
                    $npfx = current($names)->getNpfx() ?: '';
                    $givn = current($names)->getGivn() ?: '';
                    $nick = current($names)->getNick() ?: '';
                    $spfx = current($names)->getSpfx() ?: '';
                    $surn = current($names)->getSurn() ?: '';
                    $nsfx = current($names)->getNsfx() ?: '';
                    $type = current($names)->getType() ?: '';
                }

                // array value
                $fams = $individual->getFams();  // self family, leave it now, note would be included in family
                $famc = $individual->getFamc();  // parent family , leave it now, note and pedi would be included in family

                // added to database
                // string value
                $sex = preg_replace('/[^MF]/', '', $individual->getSex());
                $uid = $individual->getUid() ?? strtoupper(str_replace('-', '', Str::uuid()));
                $resn = $individual->getResn();
                $rin = $individual->getRin();
                $rfn = $individual->getRfn();
                $afn = $individual->getAfn();
                $titl = $individual->getAttr();

The assignment to $titl is dead and can be removed.

                $birt = $individual->getBirt();
                $birthday = $birt->dateFormatted ?? null;

                $birth_month = $birt->month ?? null;
                $birth_year = $birt->year ?? null;
                $birthday_dati = $birt->dati ?? null;
                $birthday_plac = $birt->plac ?? null;

                $deat = $individual->getDeat();
                $deathday = $deat->dateFormatted ?? null;
                $death_month = $deat->month ?? null;
                $death_year = $deat->year ?? null;
                $deathday_dati = $deat->dati ?? null;
                $deathday_plac = $deat->plac ?? null;
                $deathday_caus = $deat->caus ?? null;

                $buri = $individual->getBuri();
                $burial_day = $buri->dateFormatted ?? null;
                $burial_month = $buri->month ?? null;
                $burial_year = $buri->year ?? null;
                $burial_day_dati = $buri->dati ?? null;
                $burial_day_plac = $buri->plac ?? null;

                $chr = $individual->getChr();
                $chr = $chr->dateFormatted ?? null;

                if ($givn == '') {
                    $givn = $name;
                }

                $config = json_encode(config('database.connections.'.$conn));

The function config was not found. Maybe you did not declare it correctly or list all dependencies?

The assignment to $config is dead and can be removed.

                $value = [
                    'gid'             => $g_id,
                    'name'            => utf8_encode($name),
                    'givn'            => utf8_encode($givn),
                    'surn'            => utf8_encode($surn),
                    'sex'             => $sex,
                    'uid'             => $uid,
                    'rin'             => $rin,
                    'resn'            => $resn,
                    'rfn'             => $rfn,
                    'afn'             => $afn,
                    'nick'            => $nick,
                    'type'            => $type,
                    'chan'            => $chan ? $chan->getDatetime() : null,
                    'nsfx'            => $nsfx,
                    'npfx'            => $npfx,
                    'spfx'            => $spfx,
                    'birthday'        => self::validateDate($birthday) ? $birthday : null,
                    'birth_month'     => $birth_month,
                    'birth_year'      => $birth_year,
                    'birthday_dati'   => utf8_encode($birthday_dati),

It seems like $birthday_dati can also be of type null; however, parameter $string of utf8_encode() does only seem to accept string, maybe add an additional type check?

                    'birthday_plac'   => utf8_encode($birthday_plac),
                    'deathday'        => $deathday,
                    'death_month'     => $death_month,
                    'death_year'      => $death_year,
                    'deathday_dati'   => $deathday_dati,
                    'deathday_plac'   => utf8_encode($deathday_plac),
                    'deathday_caus'   => $deathday_caus,
                    'burial_day'      => $burial_day,
                    'burial_month'    => $burial_month,
                    'burial_year'     => $burial_year,
                    'burial_day_dati' => $burial_day_dati,
                    'burial_day_plac' => $burial_day_plac,
                    'titl'            => array_key_exists('TITL', $attr) ? $attr['TITL'][0]->getAttr('TITL') : null,
                    'famc'            => $famc ? $famc[0]->getFamc() : null,
                    'fams'            => $fams ? $fams[0]->getFams() : null,
                    'chr'             => $chr,
                ];

                $parentData[] = $value;
            }

            $chunk = array_chunk($parentData, 500);

The variable $parentData seems to be defined by a foreach iteration on line 34. Are you sure the iterator is never empty, otherwise this variable is not defined?

            foreach ($chunk as $item) {
                // it's take only 1 second for 3010 record
                $a = Person::on($conn)->upsert($item, ['uid']);
            }

            otherFields::insertOtherFields($conn, $individuals, $obje_ids, $sour_ids);

            return $parentData;
        } catch (\Exception $e) {
            return \Log::error($e);
        }
    }

    private static function validateDate($date, $format = 'Y-m-d')
    {
        $d = \DateTime::createFromFormat($format, $date);
        // The Y ( 4 digits year ) returns TRUE for any integer with any number of digits so changing the comparison from == to === fixes the issue.
        return $d && $d->format($format) === $date;
    }
}