familytree365 / backend

app/Http/Controllers/NoteController.php

<?php

namespace App\Http\Controllers;

use App\Models\Note;
use Illuminate\Http\Request;

class NoteController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        $query = Note::query();

        if ($request->has('searchTerm')) {
            $columnsToSearch = ['note', 'rin', 'name', 'description', 'is_active', 'type_id', 'group'];
            $search_term = json_decode($request->searchTerm)->searchTerm;
            if (! empty($search_term)) {
                $searchQuery = '%'.$search_term.'%';
                foreach ($columnsToSearch as $column) {
                    $query->orWhere($column, 'LIKE', $searchQuery);
                }
            }
        }

        if ($request->has('columnFilters')) {
            $filters = get_object_vars(json_decode($request->columnFilters));

            foreach ($filters as $key => $value) {
                if (! empty($value)) {
                    $query->orWhere($key, 'like', '%'.$value.'%');
                }
            }
        }

        if ($request->has('sort.0')) {
            $sort = json_decode($request->sort[0]);
            $query->orderBy($sort->field, $sort->type);
        }

        if ($request->has('perPage')) {
            $rows = $query->paginate($request->perPage);
        }

        return $rows;

The variable $rows does not seem to be defined for all execution paths leading up to this point.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $request->validate([
            'name' => 'required',

        ]);

        return Note::create([

The expression return App\Models\Note::create(array('note' => $request->note, 'rin' => $request->rin, 'name' => $request->name, 'description' => $request->description, 'is_active' => $request->is_active, 'type_id' => $request->type_id, 'group' => $request->group, 'date' => $request->date)) also could return the type App\Models\Note which is incompatible with the documented return type Illuminate\Http\Response.

            'note' => $request->note,
            'rin' => $request->rin,
            'name' => $request->name,
            'description' => $request->description,
            'is_active' => $request->is_active,
            'type_id' => $request->type_id,
            'group' => $request->group,
            'date' => $request->date,
        ]);
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        return Note::find($id);

The expression return App\Models\Note::find($id) also could return the type App\Models\Note which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $request->validate([
            'name' => 'required',
        ]);

        $note = Note::find($id);
        $note->note = $request->note;
        $note->rin = $request->rin;
        $note->name = $request->name;
        $note->description = $request->description;
        $note->is_active = $request->is_active;
        $note->type_id = $request->type_id;
        $note->group = $request->group;
        $note->date = $request->date;
        $note->save();

        return $note;

The expression return $note also could return the type App\Models\Note which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        $note = Note::find($id);
        if ($note) {
            $note->delete();

            return 'true';

The expression return 'true' returns the type string which is incompatible with the documented return type Illuminate\Http\Response.

        }

        return 'false';

The expression return 'false' returns the type string which is incompatible with the documented return type Illuminate\Http\Response.

    }
}