familytree365 / backend

app/Http/Controllers/DnaController.php

<?php

namespace App\Http\Controllers;

use App\Jobs\DnaMatching;
use App\Models\Dna;
use Auth;
use Illuminate\Http\Request;

class DnaController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        $query = Dna::query();

        if ($request->has('searchTerm')) {
            $columnsToSearch = ['name'];
            $search_term = json_decode($request->searchTerm)->searchTerm;
            if (! empty($search_term)) {
                $searchQuery = '%'.$search_term.'%';
                foreach ($columnsToSearch as $column) {
                    $query->orWhere($column, 'LIKE', $searchQuery);
                }
            }
        }

        if ($request->has('columnFilters')) {
            $filters = get_object_vars(json_decode($request->columnFilters));

            foreach ($filters as $key => $value) {
                if (! empty($value)) {
                    $query->orWhere($key, 'like', '%'.$value.'%');
                }
            }
        }

        if ($request->has('sort.0')) {
            $sort = json_decode($request->sort[0]);
            $query->orderBy($sort->field, $sort->type);
        }

        if ($request->has('perPage')) {
            $rows = $query->paginate($request->perPage);
        }

        return $rows;

The variable $rows does not seem to be defined for all execution paths leading up to this point.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        if ($request->hasFile('file')) {
            if ($request->file('file')->isValid()) {
                try {
                    $currentUser = Auth::user();
                    $file_name = 'dna_'.$request->file('file')->getClientOriginalName().uniqid().'.'.$request->file('file')->extension();
                    $request->file->storeAs('dna', $file_name);
                    define('STDIN', fopen('php://stdin', 'r'));
                    $random_string = unique_random('dnas', 'variable_name', 5);
                    $var_name = 'var_'.$random_string;
                    $filename = 'app/dna/'.$file_name;

The assignment to $filename is dead and can be removed.

                    $user_id = $currentUser->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                    $dna = new Dna();
                    $dna->name = 'DNA Kit for user '.$user_id;
                    $dna->user_id = $user_id;
                    $dna->variable_name = $var_name;
                    $dna->file_name = $file_name;
                    $dna->save();
                    DnaMatching::dispatch($currentUser, $var_name, $file_name);

                    return [

The expression return array('message' => __('The dna was successfully created'), 'redirect' => 'dna.edit', 'param' => array('dna' => $dna->id)) returns the type array<string,array|array<string,integer>|string> which is incompatible with the documented return type Illuminate\Http\Response.

                        'message' => __('The dna was successfully created'),
                        'redirect' => 'dna.edit',
                        'param' => ['dna' => $dna->id],
                    ];
                } catch (\Exception $e) {
                    return $e->getMessage();

The expression return $e->getMessage() returns the type string which is incompatible with the documented return type Illuminate\Http\Response.

                }
            }

            return ['File corrupted'];

The expression return array('File corrupted') returns the type array<integer,string> which is incompatible with the documented return type Illuminate\Http\Response.

        }

        return response()->json(['Not uploaded'], 422);

The expression return response()->json(array('Not uploaded'), 422) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        return Dna::find($id);

The expression return App\Models\Dna::find($id) also could return the type App\Models\Dna which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)

The parameter $request is not used and could be removed.

The parameter $id is not used and could be removed.

    {
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        $user = auth()->user();
        $dna = Dna::find($id);
        if ($user->id == $dna->user_id) {
            $dna->delete();

            return [

The expression return array('message' => __('The dna was successfully deleted'), 'redirect' => 'dna.index') returns the type array<string,array|string> which is incompatible with the documented return type Illuminate\Http\Response.

                'message' => __('The dna was successfully deleted'),
                'redirect' => 'dna.index',
            ];
        } else {
            return [

The expression return array('message' => __('The dna could not be deleted'), 'redirect' => 'dna.index') returns the type array<string,array|string> which is incompatible with the documented return type Illuminate\Http\Response.

                'message' => __('The dna could not be deleted'),
                'redirect' => 'dna.index',
            ];
        }
    }
}