familytree365 / backend

app/Http/Controllers/CitationController.php

<?php

namespace App\Http\Controllers;

use App\Models\Citation;
use Illuminate\Http\Request;

class CitationController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        $query = Citation::query();

        if ($request->has('searchTerm')) {
            $columnsToSearch = ['name', 'description', 'date', 'is_active', 'volume', 'page', 'confidence', 'source_id'];
            $search_term = json_decode($request->searchTerm)->searchTerm;
            if (! empty($search_term)) {
                $searchQuery = '%'.$search_term.'%';
                foreach ($columnsToSearch as $column) {
                    $query->orWhere($column, 'LIKE', $searchQuery);
                }
            }
        }

        if ($request->has('columnFilters')) {
            $filters = get_object_vars(json_decode($request->columnFilters));

            foreach ($filters as $key => $value) {
                if (! empty($value)) {
                    $query->orWhere($key, 'like', '%'.$value.'%');
                }
            }
        }

        if ($request->has('sort.0')) {
            $sort = json_decode($request->sort[0]);
            $query->orderBy($sort->field, $sort->type);
        }

        if ($request->has('perPage')) {
            $rows = $query->paginate($request->perPage);
        }

        return $rows;

The variable $rows does not seem to be defined for all execution paths leading up to this point.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        //
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $request->validate([
            'name' => 'required',
            'description' => 'required',
            'volume' => 'required',
            'page' => 'required',
            'is_active' => 'required',
            'confidence' => 'required',
            'source_id' => 'required',
        ]);

        return Citation::create([

The expression return App\Models\Citation::create(array('name' => $request->name, 'description' => $request->description, 'date' => $request->date, 'volume' => $request->volume, 'page' => $request->page, 'is_active' => $request->is_active, 'confidence' => $request->confidence, 'source_id' => $request->source_id)) also could return the type App\Models\Citation which is incompatible with the documented return type Illuminate\Http\Response.

            'name' => $request->name,
            'description' => $request->description,
            'date' => $request->date,
            'volume' => $request->volume,
            'page' => $request->page,
            'is_active' => $request->is_active,
            'confidence' => $request->confidence,
            'source_id' => $request->source_id,
        ]);
    }

    /**
     * Display the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        return Citation::find($id);

The expression return App\Models\Citation::find($id) also could return the type App\Models\Citation which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function edit($id)

The parameter $id is not used and could be removed.

    {
        //
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $request->validate([
            'name' => 'required',
            'description' => 'required',
            'volume' => 'required',
            'page' => 'required',
            'is_active' => 'required',
            'confidence' => 'required',
            'source_id' => 'required',
        ]);

        $citation = Citation::find($id);
        $citation->name = $request->name;
        $citation->description = $request->description;
        $citation->date = $request->date;
        $citation->volume = $request->volume;
        $citation->page = $request->page;
        $citation->is_active = $request->is_active;
        $citation->confidence = $request->confidence;
        $citation->source_id = $request->source_id;
        $citation->save();

        return $citation;

The expression return $citation also could return the type App\Models\Citation which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        $citation = Citation::find($id);
        if ($citation) {
            $citation->delete();

            return 'true';

The expression return 'true' returns the type string which is incompatible with the documented return type Illuminate\Http\Response.

        }

        return 'false';

The expression return 'false' returns the type string which is incompatible with the documented return type Illuminate\Http\Response.

    }
}