familytree365 /
backend
| Conditions | 10 |
| Paths | 48 |
| Total Lines | 38 |
| Code Lines | 21 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 15 | public function index(Request $request) |
||
| 16 | { |
||
| 17 | $query = Person::query(); |
||
| 18 | |||
| 19 | if ($request->has('searchTerm')) { |
||
| 20 | $columnsToSearch = ['title', 'name', 'appellative', 'uid', 'email', 'phone', 'birthday', 'deathday', 'bank', 'bank_account', 'obs', 'givn', 'surn', 'type', 'npfx', 'nick', 'spfx', 'nsfx', 'secx', 'description', 'child_in_family_id', 'chan', 'rin', 'resn', 'rfn', 'afn']; |
||
| 21 | $search_term = json_decode($request->searchTerm)->searchTerm; |
||
| 22 | if (! empty($search_term)) { |
||
| 23 | $searchQuery = '%'.$search_term.'%'; |
||
| 24 | foreach ($columnsToSearch as $column) { |
||
| 25 | $query->orWhere($column, 'LIKE', $searchQuery); |
||
| 26 | } |
||
| 27 | } |
||
| 28 | } |
||
| 29 | |||
| 30 | if ($request->has('columnFilters')) { |
||
| 31 | $filters = get_object_vars(json_decode($request->columnFilters)); |
||
| 32 | |||
| 33 | foreach ($filters as $key => $value) { |
||
| 34 | if (! empty($value)) { |
||
| 35 | $query->orWhere($key, 'like', '%'.$value.'%'); |
||
| 36 | } |
||
| 37 | } |
||
| 38 | } |
||
| 39 | |||
| 40 | if ($request->has('sort.0')) { |
||
| 41 | $sort = json_decode($request->sort[0]); |
||
| 42 | $query->orderBy($sort->field, $sort->type); |
||
| 43 | } |
||
| 44 | |||
| 45 | if ($request->has('perPage')) { |
||
| 46 | $rows = $query->paginate($request->perPage); |
||
| 47 | } |
||
| 48 | if (! count($request->all())) { |
||
| 49 | $rows = $query->get()->toArray(); |
||
| 50 | } |
||
| 51 | |||
| 52 | return $rows; |
||
|
Comprehensibility
Best Practice
introduced
by
|
|||
| 53 | } |
||
| 194 |
Loading history...
